Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustrover 2024.1,241.15989.199 #174640

Merged
merged 1 commit into from
May 23, 2024
Merged

rustrover 2024.1,241.15989.199 #174640

merged 1 commit into from
May 23, 2024

Conversation

samford
Copy link
Member

@samford samford commented May 23, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

RustRover is now released but the existing livecheck block restricts the check to EAP (unstable) versions and incorrectly returns 2024.1,241.15989.180 (the newest EAP release) as the latest version. This updates the livecheck block to only check stable (release) versions going forward and updates the cask to 2024.1,241.15989.199.

The stable dmg files use the version (2024.1) instead of the build (241.15989.199), so we unfortunately have to use sha256 :no_check now, as the dmg can be updated to a new build without any change to the file name.

@samford samford added the livecheck Issues or PRs related to livecheck label May 23, 2024
RustRover is now released but the existing `livecheck` block restricts
the check to EAP (unstable) versions and incorrectly returns
2024.1,241.15989.180 (the newest EAP release) as the latest version.
This updates the `livecheck` block to only check stable (`release`)
versions going forward and updates the cask to 2024.1,241.15989.199.

The stable dmg files use the version (`2024.1`) instead of the build
(`241.15989.199`), so we unfortunately have to use `sha256 :no_check`
now, as the dmg can be updated to a new build without any change
to the file name.
@samford samford force-pushed the rustrover-2024.1,241.15989.199 branch from 3e7b5d4 to e7c4e64 Compare May 23, 2024 12:37
@miccal miccal merged commit ddc4957 into master May 23, 2024
9 checks passed
@miccal miccal deleted the rustrover-2024.1,241.15989.199 branch May 23, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
livecheck Issues or PRs related to livecheck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants