workflows: enable commit signing for BrewTestBot #105988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rylan12
added
the
ci-syntax-only
9 tasks
MikeMcQuaid
approved these changes
May 18, 2021
SMillerDev
approved these changes
May 18, 2021
|
@nandahkrishna is there an easy way for us to test this out or should we just merge and assume it will work (I'll try to keep an eye out for failed workflows or unsigned commits in PRs) |
|
Do we have a way to manually run any of these workflows? We could try creating a test PR (perhaps with |
|
So the I think I'd feel comfortable merging without testing because this is something that works in lots of other places |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
setup-commit-signingaction to enable commit signing for BrewTestBot, wherever required. See Homebrew/brew#11403.CC @nandahkrishna