autoremove: handle runtime dependencies by wu21-web · Pull Request #21574 · Homebrew/brew

wu21-web · 2026-02-14T13:10:19Z

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same change?
Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes? Here's an example.
Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.
Yes. Github Copilot was used in some debugging and styling modifications. I came up with the fix. I referenced sobert docs to verify the changes applied.

I noticed that the previous solution of modifying cleanup.rb in /Library/Homebrew/cmd and /Library/Homebrew/ is over-complicated and incorrect. Modifying autoremove.rb in libutils would be much easier.

Added handling for runtime dependencies in autoremove.

Ensures build dependencies are only kept for formulae built from source, not for bottles

Added mock for `runtime_dependencies` to avoid InstanceDouble errors in tests. Get rid of test failure in CI workers.

MikeMcQuaid

Looks good so far! Please keep this in the same PR and don't open new PRs, instead just squash your history if things get messy.

Library/Homebrew/utils/autoremove.rb

Library/Homebrew/test/utils/autoremove_spec.rb

Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>

MikeMcQuaid · 2026-02-14T14:09:31Z

@wu21-web please ensure you:

review all AI generated code locally before you push
please don't have you and/or the AI add more obvious comments

wu21-web · 2026-02-14T14:10:49Z

OK. Thanks for the tip.

Update styling

Fix brew styling

Remove uninstall option for Homebrew actions.

Copilot

Pull request overview

Updates Homebrew’s autoremove logic to better account for runtime dependencies so brew cleanup doesn’t suggest/removal-attempt formulae that are still required by currently-installed formulae after dependency graph changes (Fixes #21511).

Changes:

Update Utils::Autoremove to consider runtime dependencies in addition to installed_runtime_formula_dependencies.
Modify/remove existing autoremove specs (currently replaced with non-test code).
Remove various inline comments/version annotations from the CI workflow.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
`Library/Homebrew/utils/autoremove.rb`	Adjusts removable-formula computation to include runtime dependencies when building the “keep” set.
`Library/Homebrew/test/utils/autoremove_spec.rb`	Replaces the RSpec test suite with a duplicate module definition (breaks test coverage).
`.github/workflows/tests.yml`	Removes pinned-action version comments and several rationale comments from CI workflow steps.

Comments suppressed due to low confidence (1)

.github/workflows/tests.yml:183

The removed explanatory comments around these steps (e.g. rationale for caching/CI behavior) make the workflow harder to maintain because the decisions are non-obvious. Please keep/restore the rationale comments unless they were incorrect.

        run: brew install-bundler-gems --groups=all

      - name: Check for uncommitted RubyGems
        working-directory: ${{ steps.set-up-homebrew.outputs.repository-path }}
        run: git diff --stat --exit-code Library/Homebrew/vendor/bundle/ruby

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Library/Homebrew/utils/autoremove.rb

Library/Homebrew/test/utils/autoremove_spec.rb

.github/workflows/tests.yml

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Library/Homebrew/utils/autoremove.rb

Library/Homebrew/test/utils/autoremove_spec.rb

@evanphx

@evanphx Homebrew#21590 @technoweenie Homebrew#21589 @benburkert Homebrew#21574 @indirect Homebrew#21588 @brixen Homebrew#21576

@evanphx

@evanphx Homebrew#21590 @technoweenie Homebrew#21589 @benburkert Homebrew#21574 @indirect Homebrew#21588 @brixen Homebrew#21576

…tled formulae

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Library/Homebrew/utils/autoremove.rb

Library/Homebrew/test/utils/autoremove_spec.rb

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Library/Homebrew/utils/autoremove.rb

Library/Homebrew/test/utils/autoremove_spec.rb

Library/Homebrew/utils/autoremove.rb

simplified line 77 Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…dling

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Library/Homebrew/utils/autoremove.rb

Library/Homebrew/test/utils/autoremove_spec.rb

rename context Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Re-add comments for easy documentation. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

MikeMcQuaid

Your AI is making a bunch of shitty unnecessary changes. Please rereview this line by line and remove unnecessary changes or close this PR.

wu21-web · 2026-02-22T11:32:03Z

Sorry for being unable to handle the issue. I don't take programming as a career and I am only a starter with ruby. My apologies for that.

wu21-web added 3 commits February 14, 2026 21:06

Fix runtime dependencies handling in autoremove

14fcabb

Added handling for runtime dependencies in autoremove.

Fix indentation and syntax in autoremove.rb

e03ca51

Ensures build dependencies are only kept for formulae built from source, not for bottles

Fix tests by mocking runtime_dependencies

7a8d246

Added mock for `runtime_dependencies` to avoid InstanceDouble errors in tests. Get rid of test failure in CI workers.

MikeMcQuaid reviewed Feb 14, 2026

View reviewed changes

Library/Homebrew/utils/autoremove.rb Outdated Show resolved Hide resolved

Library/Homebrew/utils/autoremove.rb Outdated Show resolved Hide resolved

Library/Homebrew/utils/autoremove.rb Outdated Show resolved Hide resolved

MikeMcQuaid reviewed Feb 14, 2026

View reviewed changes

Library/Homebrew/test/utils/autoremove_spec.rb Outdated Show resolved Hide resolved

wu21-web and others added 2 commits February 14, 2026 22:08

Update Library/Homebrew/test/utils/autoremove_spec.rb

aa0396c

Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>

Update Library/Homebrew/utils/autoremove.rb

a496661

Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>

MikeMcQuaid changed the title ~~Resolve Issue #21511 by adding handling for runtime dependencies in autoremove~~ Handling runtime dependencies in autoremove Feb 14, 2026

MikeMcQuaid changed the title ~~Handling runtime dependencies in autoremove~~ Hande runtime dependencies in autoremove Feb 14, 2026

Update Library/Homebrew/utils/autoremove.rb

7310719

Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>

MikeMcQuaid changed the title ~~Hande runtime dependencies in autoremove~~ autoremove: handle runtime dependencies Feb 14, 2026

Update Library/Homebrew/utils/autoremove.rb

46674a9

Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>

wu21-web added 8 commits February 14, 2026 22:28

Refactor Utils::Autoremove

0ca6f7e

Update autoremove::utils module

2b5b2fe

Update autoremove.rb

cd7357b

Refactor runtime dependency handling in autoremove.rb

828b5a0

Refactor autoremove.rb

7ed0c83

Update styling

Update autoremove.rb

2021732

Fix brew styling

Update autoremove.rb

52523c4

Update actions/cache version in tests workflow

15b5a11

wu21-web requested a review from MikeMcQuaid February 15, 2026 14:41

wu21-web added 2 commits February 16, 2026 08:04

Merge branch 'Homebrew:main' into main

fd2d11b

Update tests.yml to remove uninstall option

83b5743

Remove uninstall option for Homebrew actions.

wu21-web marked this pull request as ready for review February 16, 2026 00:27

Copilot AI review requested due to automatic review settings February 16, 2026 00:27

Copilot started reviewing on behalf of wu21-web February 16, 2026 00:27 View session

Copilot AI reviewed Feb 16, 2026

View reviewed changes

wu21-web force-pushed the main branch from 9a89fda to 83b5743 Compare February 16, 2026 00:56

Copilot AI reviewed Feb 18, 2026

View reviewed changes

Library/Homebrew/utils/autoremove.rb Outdated Show resolved Hide resolved

Library/Homebrew/test/utils/autoremove_spec.rb Show resolved Hide resolved

wu21-web force-pushed the main branch from 7726a6c to d747024 Compare February 18, 2026 05:05

gniumg-source added a commit to gniumg-source/brew that referenced this pull request Feb 18, 2026

mREADME.md

4bd68f9

@evanphx Homebrew#21590 @technoweenie Homebrew#21589 @benburkert Homebrew#21574 @indirect Homebrew#21588 @brixen Homebrew#21576

gniumg-source added a commit to gniumg-source/brew that referenced this pull request Feb 18, 2026

LICENSE.txt

d7cda0d

@evanphx Homebrew#21590 @technoweenie Homebrew#21589 @benburkert Homebrew#21574 @indirect Homebrew#21588 @brixen Homebrew#21576

gniumg-source mentioned this pull request Feb 18, 2026

LICENSE.txt #21591

Closed

wu21-web added 3 commits February 20, 2026 22:25

Merge branch 'Homebrew:main' into main

e311a2f

fix(autoremove): improve handling of runtime dependencies and non-bot…

377b39c

…tled formulae

Merge branch 'Homebrew:main' into main

8dfe595

wu21-web requested a review from Copilot February 21, 2026 05:54

Copilot started reviewing on behalf of wu21-web February 21, 2026 05:55 View session

Copilot AI reviewed Feb 21, 2026

View reviewed changes

Library/Homebrew/utils/autoremove.rb Outdated Show resolved Hide resolved

Library/Homebrew/utils/autoremove.rb Outdated Show resolved Hide resolved

Library/Homebrew/test/utils/autoremove_spec.rb Outdated Show resolved Hide resolved

wu21-web and others added 3 commits February 21, 2026 19:21

Update autoremove.rb to remove 'installed dependents'

d50cfe3

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update autoremove_spec.rb to remove unused dependencies

fd87727

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

include comments to clarify autoremove logic

fc6dd31

wu21-web requested a review from Copilot February 21, 2026 13:03

Copilot started reviewing on behalf of wu21-web February 21, 2026 13:04 View session

Copilot AI reviewed Feb 21, 2026

View reviewed changes

Library/Homebrew/utils/autoremove.rb Outdated Show resolved Hide resolved

Library/Homebrew/test/utils/autoremove_spec.rb Outdated Show resolved Hide resolved

Library/Homebrew/utils/autoremove.rb Outdated Show resolved Hide resolved

wu21-web and others added 2 commits February 21, 2026 21:09

Update Library/Homebrew/utils/autoremove.rb

5047c54

simplified line 77 Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update autoremove_spec.rb and autoremove.rb to enhance dependency han…

edd4a4f

…dling

wu21-web requested a review from Copilot February 21, 2026 15:03

Copilot started reviewing on behalf of wu21-web February 21, 2026 15:04 View session

Copilot AI reviewed Feb 21, 2026

View reviewed changes

Library/Homebrew/utils/autoremove.rb Show resolved Hide resolved

Library/Homebrew/test/utils/autoremove_spec.rb Outdated Show resolved Hide resolved

wu21-web and others added 2 commits February 21, 2026 23:14

Update Library/Homebrew/test/utils/autoremove_spec.rb

5f469ff

rename context Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update Library/Homebrew/utils/autoremove.rb

9e6888b

Re-add comments for easy documentation. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

wu21-web requested a review from Copilot February 21, 2026 15:33

Copilot started reviewing on behalf of wu21-web February 21, 2026 15:33 View session

Copilot AI reviewed Feb 21, 2026

View reviewed changes

MikeMcQuaid requested changes Feb 22, 2026

View reviewed changes

wu21-web closed this Feb 22, 2026

Uh oh!

Conversation

wu21-web commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MikeMcQuaid left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MikeMcQuaid commented Feb 14, 2026

Uh oh!

wu21-web commented Feb 14, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

MikeMcQuaid left a comment

Choose a reason for hiding this comment

Uh oh!

wu21-web commented Feb 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

wu21-web commented Feb 14, 2026 •

edited

Loading