Skip to content

Resolving Issue #16669 - Anonymous OCI registry mirror support #19885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

byjrack
Copy link

@byjrack byjrack commented May 2, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?

Currently an Authorization header is added to all requests for CurlGithubPackageDownload. It includes the contents of an ARTIFACT_TOKEN auth var or "A" which is used for access to ghcr.io. This causes an issue though if you host a private mirror of GHCR where auth is optional. This adds a conditional where for 7 of the 8 cases it adds the header, but for the 1 where you have a DOMAIN set and not TOKENs it will skip adding the header.

I couldn't figure out a great way to test this given the environmental aspects, but I am up for suggestions and can tweak the PR to fit.

  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@byjrack
Copy link
Author

byjrack commented May 5, 2025

So may need a pointer on this one. Was able to get the style stuff taken care of, but not sure if I follow the issue with the tests output. Is that because i didn't add a new test for this specific scenario?

@byjrack
Copy link
Author

byjrack commented May 12, 2025

Any maintainer have any pointers on what changes I need to add for the failed CI task? Happy to give it another shot, but not sure I am following what is being flagged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant