Resolving Issue #16669 - Anonymous OCI registry mirror support #19885
+6
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently an Authorization header is added to all requests for CurlGithubPackageDownload. It includes the contents of an
ARTIFACT_TOKEN
auth var or "A" which is used for access to ghcr.io. This causes an issue though if you host a private mirror of GHCR where auth is optional. This adds a conditional where for 7 of the 8 cases it adds the header, but for the 1 where you have aDOMAIN
set and notTOKEN
s it will skip adding the header.I couldn't figure out a great way to test this given the environmental aspects, but I am up for suggestions and can tweak the PR to fit.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?