Fix wildcard copy in cask updates.#15407
Merged
reitermarkus merged 11 commits intoHomebrew:masterfrom May 12, 2023
Merged
Conversation
Fixes one of the errors in https://github.com/orgs/Homebrew/discussions/4498 (specifically "cp: [...].app/*: No such file or directory").
carlocab
reviewed
May 11, 2023
reitermarkus
approved these changes
May 12, 2023
reitermarkus
changed the title
Member
|
Thanks, @JBYoshi! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?This fixes a regression in #15138 where the copying step may fail with a "cp: [...].app/*: No such file or directory" error. (This is one of the errors documented in https://github.com/orgs/Homebrew/discussions/4498.) This PR also adds a unit test to cover the relevant portion of the code.