Skip to content

dev-cmd/audit: remove unused warnings key. #15269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MikeMcQuaid merged 1 commit into from
Apr 19, 2023
Merged

dev-cmd/audit: remove unused warnings key. #15269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 14 additions & 17 deletions Library/Homebrew/dev-cmd/audit.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ def self.audit
end
end

[f.path, { errors: fa.problems + fa.new_formula_problems, warnings: [] }]
[f.path, fa.problems + fa.new_formula_problems]
end

cask_results = if audit_casks.empty?
Expand Down Expand Up @@ -272,11 +272,11 @@ def self.audit
only: args.only,
except: args.except,
)
[cask.sourcefile_path, { errors: errors, warnings: [] }]
[cask.sourcefile_path, errors]
end
end

failed_casks = cask_results.reject { |_, result| result[:errors].empty? }
failed_casks = cask_results.select { |_, problems| problems.present? }

cask_count = failed_casks.count

Expand Down Expand Up @@ -309,20 +309,17 @@ def self.audit

return unless ENV["GITHUB_ACTIONS"]

annotations = formula_results.merge(cask_results).flat_map do |path, result|
(
result[:warnings].map { |w| [:warning, w] } +
result[:errors].map { |e| [:error, e] }
).map do |type, problem|
GitHub::Actions::Annotation.new(
type,
problem[:message],
file: path,
line: problem[:location]&.line,
column: problem[:location]&.column,
)
end
end
annotations = formula_results.merge(cask_results).flat_map do |path, problem|
next if problem.blank?

GitHub::Actions::Annotation.new(
:error,
problem[:message],
file: path,
line: problem[:location]&.line,
column: problem[:location]&.column,
)
end.compact

annotations.each do |annotation|
puts annotation if annotation.relevant?
Expand Down