Skip to content

fix: also check the beschreibung of an Anwendungsfall for is_outdated #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hf-kklein merged 2 commits into from
Dec 17, 2025
Merged

fix: also check the beschreibung of an Anwendungsfall for is_outdated #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af692af
fix: also check the beschreibung of an Anwendungsfall for `is_outdated`
Dec 17, 2025
c99cc27
snapshot
Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/fundamend/models/anwendungshandbuch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,10 +146,13 @@ class Anwendungsfall(FundamendBaseModel):
def is_outdated(self) -> bool:
"""
the experts creating the XMLs thought it was a good idea to encode the information if something is there just
for legacy reasons in the prüfidentifikator attribute - where else.
It's not like they could've added just another attribute to indicate that.
for legacy reasons in the prüfidentifikator or beschreibung attribute - where else.
It's not like they could've added just another boolean attribute to indicate that or just remove the outdated
data entirely - probably they don't even use version control, so it stays in the XML as a backup.
"""
return "##alt##" in self.pruefidentifikator.lower() # table flip moment
return (
"##alt##" in self.pruefidentifikator.lower() or "wird nicht mehr verwendet" in self.beschreibung.lower()
) # table flip moments

@property
def kommunikationsrichtungen(self) -> list[Kommunikationsrichtung] | None:
Expand Down
1 change: 0 additions & 1 deletion unittests/__snapshots__/test_ahbreader.ambr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
'#nv# Anfrage an MSB mit Abhängigkeiten',
'#nv# Nicht bila.rel. Änderung vom LF',
'(Ankündigung) Zuordnung des LF zur erz. MaLo/ Tranche',
'...wird nicht mehr verwendet...',
'Ab-/Bestellung BK-SZR auf Aggregationsebene RZ',
'Abbestellung von Werten',
'Abl. der Anforderung',
Expand Down