perf(v_ahb_diff): make view less general purpose but faster
#228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this change restricts the use of `v_ahb_diff` to compare the SAME prüfidentifikator between 2 format versions where the older version is actually older than the newer. before this change you could also compare in the opposite direction or compare different prüfidentifikators. this is no longer possible. but we get significant performance gains.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the v_ahb_diff database view by restricting its usage to compare the same prüfidentifikator across format versions where the older version chronologically precedes the newer version. The optimization trades generality for performance by eliminating unnecessary comparison combinations.
Key Changes:
- Restricted comparisons to matching prüfidentifikators only
- Added constraint that old format version must be less than new format version
- Updated documentation to reflect the new limitations introduced in version 0.32
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change restricts the use of
v_ahb_diffto compare the SAME prüfidentifikator between 2 format versions where the older version is actually older than the newer.before this change you could also compare in the opposite direction or compare different prüfidentifikators. this is no longer possible. but we get significant performance gains.