refactor(test): add shared fixture session_fv2410_fv2504_with_diff_view
#218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the FV2410+FV2504 database fixture from test_ahb_diff_view.py to conftest.py to enable reuse across multiple test files. Changes: - Created `session_fv2410_fv2504_with_diff_view` fixture in conftest.py with meaningful name that includes the format versions involved - Renamed fixture from `diff_view_session` to the more descriptive name - Module-scoped fixture creates DB with ahb_hierarchy_materialized, ahb_expressions, v_ahbtabellen, and v_ahb_diff views - Updated all invariant tests in test_ahb_diff_view.py to use the shared fixture This enables potential future sharing of the expensive FV2410+FV2504 database creation (~30s) across other test files that need to compare these two format versions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
|
claudes guess about "only 30s" saved. is wrong. it should be way more. |
hf-kklein
changed the title
session_fv2410_fv2504_with_diff_view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the FV2410+FV2504 database fixture from test_ahb_diff_view.py to
conftest.py to enable reuse across multiple test files.
Changes:
session_fv2410_fv2504_with_diff_viewfixture in conftest.pywith meaningful name that includes the format versions involved
diff_view_sessionto the more descriptive nameahb_expressions, v_ahbtabellen, and v_ahb_diff views
shared fixture
This enables potential future sharing of the expensive FV2410+FV2504
database creation (~30s) across other test files that need to compare
these two format versions.
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com