perf: speed up bulk inserts in create_db_and_populate_with_ahb_view
#214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the performance of bulk insert operations in create_db_and_populate_with_ahb_view by applying SQLite-specific PRAGMA settings and batching inserts.
Key changes:
- Add SQLite PRAGMA optimizations for faster bulk inserts (disable synchronous writes, enable WAL mode, increase cache size, use memory for temp storage, and set exclusive locking during bulk operations)
- Replace individual
session.add()calls with batchedsession.add_all()for better performance - Remove redundant
session.flush()calls that are unnecessary when followed bysession.commit()
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
hope shit helps... it's more annoying than expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.