feat(tui): priority-ordered footer hint dropping for narrow terminals - #107
Merged
Conversation
Rework `FooterWidget::status_line_spans` so the footer never wraps
mid-hint at any width. Hints now drop in priority order:
1. mode label (always visible; truncated only as a last resort)
2. model name (always visible alongside mode; truncated mid-word only
after status has already been dropped)
3. status label ("working", "draft", "refreshing context", ...) — drops
first when space is tight
Previously the model name would ellipsize the moment a long status
label crowded the line, even at 60–80 columns. The new tier system
keeps mode + model intact down to ~25 cols and only falls back to
mode-only on extreme narrow widths.
Includes snapshot-style tests at widths 40, 60, 80, 100, 120 covering
the full / drop-status / truncate-model / mode-only tiers.
Fixes #88
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the TUI footer's status line to implement a priority-ordered dropping mechanism, ensuring the footer remains on a single line across various widths. The logic prioritizes the mode label, followed by the model name, and finally the status label. A new helper method build_status_line_spans was introduced to consolidate span creation, and extensive unit tests were added to verify the truncation behavior at different column widths. One improvement was identified regarding an unnecessary heap allocation when rendering the mode label.
Comment on lines
317
to
320
| return vec![Span::styled( | ||
| truncate_to_width(mode_label, max_width), | ||
| mode_label.to_string(), | ||
| Style::default().fg(self.props.mode_color), | ||
| )]; |
Contributor
There was a problem hiding this comment.
mode_label is a &'static str. Since Span::styled can accept it directly to produce a Span<'static>, calling .to_string() here is an unnecessary heap allocation in the render loop.
Suggested change
| return vec![Span::styled( | |
| truncate_to_width(mode_label, max_width), | |
| mode_label.to_string(), | |
| Style::default().fg(self.props.mode_color), | |
| )]; | |
| return vec![Span::styled( | |
| mode_label, | |
| Style::default().fg(self.props.mode_color), | |
| )]; |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
MMMarcinho
pushed a commit
to MMMarcinho/DeepSeek-TUI
that referenced
this pull request
May 6, 2026
feat(tui): priority-ordered footer hint dropping for narrow terminals
9 tasks
timothybrush
pushed a commit
to timothybrush/DeepSeek-TUI
that referenced
this pull request
Aug 16, 2026
Privileged release workflows no longer attach rust-cache, sccache, or npm caches to a workflow_dispatch checkout (CodeQL Hmbown#88-Hmbown#106). Catalog drift no longer prints raw bundled/upstream blobs (Hmbown#107).
Hmbown
pushed a commit
that referenced
this pull request
Aug 17, 2026
All 19 open actions/cache-poisoning/poisonable-step alerts (#88-#106) sit in release.yml, release-candidate.yml and release-artifacts.yml: jobs interpolated the caller SHA into ref/caches and let setup-node's implicit npm cache key on run identity. Now caller source_sha is pinned against github.sha by a pin job (refusing any retarget), checkout and build identity use GITHUB_SHA through env indirection instead of template interpolation, rust-cache keys use stable prefix-key values, and setup-node's implicit package cache is off where it cannot be keyed safely. Also carries the CodeQL #107 fix from the same lane: catalog_models_dev.py prints remote limit values as numbers/null/redacted only and drops query and fragment material from source URLs before logging. Harvested from #5401 (workflow+script files; CHANGELOG edit intentionally excluded here and lands with the release branch; GHSA advisory text split to a later PR as advised). No-Issue: CodeQL alert remediation (alerts #88-#107); no single user-facing issue tracks these Signed-off-by: Hunter Bown <hunter@hmbown.com>
This was referenced Aug 17, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FooterWidget::status_line_spansto use priority-ordered hint dropping so the footer never wraps mid-hint at any terminal width.Fixes #88
Test plan
cargo fmt --all -- --checkcargo clippy -p deepseek-tui --all-targets --all-features --locked -- -D warningscargo test -p deepseek-tui --bin deepseek-tui --locked(1001 passed, 0 failed)