Skip to content

main is red on both platforms across all four completed runs: plugin_e2e_acceptance on macOS, NSIS provisioning on Windows #5403

Description

@Lstarsky0

Now that #5395 stopped main runs from cancelling each other, they complete — and the four that have completed since are red on both platforms. Posting the set because the verdicts are new information rather than a new breakage.

commit macOS Windows
ee1f9cb9e agy_credentials ×4 NSIS install
dd0fbed81 agy_credentials ×4 NSIS install
ad102ec44 plugin_e2e_acceptance NSIS install
5ac75add4 plugin_e2e_acceptance NSIS install

Two separate causes, and neither is a flake.

macOS — plugin_e2e_acceptance was hiding behind the agy failures

test plugin_e2e_acceptance::plugin_toml_binary_lifecycle_skill_and_stdio_mcp_acceptance ... FAILED
test result: FAILED. 25 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 82.49s

The macOS leg has been red on every run; what changed at ad102ec44 is only which test reports it. #5396 fixed the four agy_credentials cases, and this one surfaced underneath.

It also fails on an unmodified main here — it is in the failure set of a full cargo test --workspace --all-features --locked --no-fail-fast I ran on a clean checkout.

The cleanest evidence that it is not anyone's diff: two of my open PRs sit on the same base with completely unrelated changes — #5397 is four Simplified Chinese copy files, #5398 is one generated TypeScript data file — and both fail this same test with the identical 25 passed; 1 failed.

Windows — a required check installs NSIS from Chocolatey at test time

Four for four, same step, two different Chocolatey symptoms:

Failed to fetch results from V2 feed at 'https://community.chocolatey.org/api/v2/Packages(Id='nsis',Version='3.12.0')'
  with following message : Response status code does not indicate success: 504 (Gateway Timeout).
nsis not installed. The package was not found with the source(s) listed.

and then, both times:

Exception: scripts\installer\installer-path-regression.tests.ps1:80
  throw 'makensis.exe was not found after installing NSIS.'

The job never reaches the Rust tests — the logs are under 200 lines and contain no test results at all. So Test (windows-latest) currently reports on Chocolatey's availability rather than on the code, and it is a required check, so every contributor's PR inherits it. Mine did: #5397's first Windows run was the 504, and a re-run after rebasing passed cleanly, which is the shape of an external dependency rather than anything in the tree.

Pinning the NSIS version to a cached artifact, or skipping the installer path regression when makensis cannot be provisioned, would both stop an outage at a third-party feed from reading as a red build. Which of those you want is a call about how much the check is meant to guarantee, so I have not sent a patch.

Happy to split this into two issues if you would rather track them apart — I kept them together because "what is main failing right now" is one question.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions