Harden packaging & smoke tests; clarify adapter compatibility wording#26
Merged
HiveForensicsAI merged 1 commit intocodex/restructure-knolo-repository-for-monorepofrom Feb 21, 2026
Conversation
bead993
into
codex/restructure-knolo-repository-for-monorepo
0 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
@knolo/cliis publish-ready with a correctbinentry, included runtime files, and a runtime semver dependency on@knolo/coreso generated apps install outside the monorepo.create-knolo-apptemplate and its smoke tests validate real-world install/build behavior using packed tarballs instead of workspace-only references.Description
packages/cli/package.jsonfor npm publishing by settingprivate: false, a realversion(0.3.1), canonicalbinmapping ("knolo": "bin/knolo.mjs"),files: ["bin/"], and a runtime dependency on@knolo/core: "^0.3.1".packages/cli/test/cli.test.mjs) that runsnpm pack, inspects the tarball entries, assertspackage/bin/knolo.mjsandpackage/package.jsonexist, and verifiestest/andsrc/are not included andpackage.jsonfields are correct.packages/create-knolo-app/template/package.jsonandpackages/create-knolo-app/test/create-knolo-app.test.mjs) to usenpm packfor@knolo/core,@knolo/cli, andcreate-knolo-app, scaffold via the packed create-app package, replace deps with local tarball paths, runnpm installandnpm run knolo:build, and assertdist/knowledge.knolois produced.Testing
npm install,npm run build, andnpm test, and the full workspace test suite completed successfully with all tests passing.npm packonpackages/cli, inspected the produced tarball, and passed assertions thatbin/knolo.mjsis present andpackage.jsonmetadata (private: false,binmapping,@knolo/core: ^0.3.1) are correct.@knolo/core,@knolo/cli, andcreate-knolo-app, scaffolded a project from the packed create-app package, installed the packed tarball dependencies, rannpm run knolo:build, and asserted thatdist/knowledge.knoloexists (test passed).Codex Task