Skip to content

Conversation

@Himenon
Copy link
Owner

@Himenon Himenon commented Apr 1, 2023

Summary

BREAKING CHANGE

related: #104 (comment)

New

export interface RequestArgs {
    httpMethod: HttpMethod;
    url: string;
    headers: ObjectLike | any;
    requestBody: ObjectLike | any;
    queryParameters: QueryParameters | undefined;
}
export interface ApiClient<RequestOption> {
    request: <T = SuccessResponses>(requestArgs: RequestArgs, options?: RequestOption) => T;
}

Old

export interface ApiClient<RequestOption> {
    request: <T = SuccessResponses>(httpMethod: HttpMethod, url: string, headers: ObjectLike | any, requestBody: ObjectLike | any, queryParameters: QueryParameters | undefined, options?: RequestOption) => Promise<T>;
}

Test Plan

snapshot

@Himenon Himenon changed the title feat: update apiClient arguments interface feat(breaking change): update apiClient arguments interface Apr 1, 2023
@Himenon Himenon merged commit a9e0a14 into main Apr 1, 2023
@Himenon Himenon deleted the feat/update-api-client-interface2 branch April 1, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants