Sourcery refactored master branch #5
Conversation
![code-review-doctor[bot]](https://avatars.githubusercontent.com/in/83430?s=60&v=4){kind=small}
There was a problem hiding this comment.
Looks good. Worth considering though. View full project report here.
| def sort_matrix(M): | ||
| result = sorted(M, key=lambda matrix_row: sum(matrix_row)) | ||
| return result | ||
| return sorted(M, key=lambda matrix_row: sum(matrix_row)) |
There was a problem hiding this comment.
| return sorted(M, key=lambda matrix_row: sum(matrix_row)) | |
| return sorted(M, key=sum) |
Avoid unnecessarily wrapping sum in a lambda. More details.
| print(f.read()) | ||
| f.close() | ||
|
|
||
| with open('exercises.txt', 'a') as f: |
There was a problem hiding this comment.
| with open('exercises.txt', 'a') as f: | |
| with open('exercises.txt', 'a', encoding='utf_8') as f: |
UnicodeEncodeError can occur if the text being written to the file contain characters not compatible with the OS's default text encoding because encoding is not set. More info.
| print(read_data) | ||
| print(f.closed) | ||
| f.close() | ||
| with open('exercises.txt') as f: |
There was a problem hiding this comment.
UnicodeDecodeError can occur if the content of the file has characters incompatible with the OS's default encoding. Python uses the OS's default text encoding on the content because encoding is not set. More details.
| print(f.readline()) | ||
| f.close() | ||
|
|
||
| with open('exercises.txt') as f: |
There was a problem hiding this comment.
Similarly, Set the encoding.
| f1 = open('exercises.txt', 'a') | ||
| f1.write(f.read()) | ||
| f.close() | ||
| with open('list-to-file.txt') as f: |
There was a problem hiding this comment.
Similarly, Set the encoding.
| f1.write(f.read()) | ||
| f.close() | ||
| with open('list-to-file.txt') as f: | ||
| f1 = open('exercises.txt', 'a') |
There was a problem hiding this comment.
| f1 = open('exercises.txt', 'a') | |
| f1 = open('exercises.txt', 'a', encoding='utf_8') |
Same as above: Set the encoding.
| for letter in string.ascii_uppercase: | ||
| with open(letter + ".txt", "w") as f: | ||
| f.writelines(letter) | ||
| with open(f"{letter}.txt", "w") as f: |
There was a problem hiding this comment.
| with open(f"{letter}.txt", "w") as f: | |
| with open(f"{letter}.txt", "w", encoding="utf_8") as f: |
Same as above: Set the encoding.
| f = open(filename, 'r') | ||
| text = f.read() | ||
| f.close() | ||
| with open(filename, 'r') as f: |
There was a problem hiding this comment.
UnicodeDecodeError can occur if the content of the file has characters incompatible with the OS's default encoding. Python uses the OS's default text encoding on the content because encoding is not set. More details.
| print("{:<5}{:<15}: {:<90}: {}, {}\n ".format(str(i)+')',hacks_final_date, hacks_name.title(), hacks_city, hacks_country)) | ||
|
|
||
| print( | ||
| "{:<5}{:<15}: {:<90}: {}, {}\n ".format( |
There was a problem hiding this comment.
f-string is easier to read, write, and less computationally expensive than legacy string formatting. Read more.
Co-authored-by: code-review-doctor[bot] <72320148+code-review-doctor[bot]@users.noreply.github.com>
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.18%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!