Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphical QR Code Scan Response Improvements #269

Merged

Conversation

grablair
Copy link
Contributor

@grablair grablair commented Oct 27, 2024

This does the following:

  1. Removes some dead, duplicated code
  2. Adds alternate, temporary QR code outline colors, depending upon the context
    1. Yellow: Check-In is in-progress. This color is activated when the check-in call is sent, then deactivates as soon as it receives a response.
    2. Green: Check-In succeeded. This color is activated when the check-in call comes back successful, the attendee was not already checked in, and will remain on for half a second.
    3. Red: Check-In failed. This color is activated when either the check-in call comes back with a failure, or the attendee was already checked in, and will remain on for half a second.

Checklist

  • I have read the contributing guidelines.
  • My code is of good quality and follows the coding standards of the project.
  • I have tested my changes, and they work as expected.

Thank you for your contribution! 🎉

@daveearley
Copy link
Contributor

Nice! Thanks for this :-) Tested and it works well.

@daveearley daveearley merged commit fd7d28f into HiEventsDev:develop Oct 28, 2024
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants