Fix laser from file hanging with MPI #1235
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1157 added a something equivalent to this in InitLaserSlice():
This hangs because the head rank is waiting for the other ranks to receive m_lambda0, but they never call MPI_Bcast and won't receive it. Some MPI implementations may not hang here due to using an internal buffer.
Since lambda0 is required to be set in the input and its asserted that that is the same as the one from the file, the MPI_Bcast can be removed without replacement.
constisconst)