copy, delete, read updates - also simplified read #1993
+109
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-implement copy and delete from LocalDiskStorageStrategy and LocalDiskStorageService into the new LocalDiskStorageController.
Read is no longer implemented in the storage strategy provided by the mountpoint service, but now exists internally in puterfs as part of the storage controller.
KernelDeimos
force-pushed
the
25BH0-main
branch
from
829f87c to
9ad3fb8
Compare
This was merged late so it needed re-testing to verify everything still works. The import for LLRead was missing, likely due to changes on upstream that removed an unused import. The wrong method for UUID validation was also used, which probably happened because of the removal of `backend-core-0`. One of these issues (LLRead) was caught by the linter but the other was not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.