Incorrect copy for switching plan

[reynaldichernando]

hi team, i'm switching from Professional to Basic plan
the message here shows that i'm now subscribed to Basic

in reality i'm still on Professional, and Basic will only activate once the current subscription period ends

the text here should also reflect that

note:
manage billing via stripe shows the correct info

reopening the change subscription popup also shows the correct thing

so its only this success popup that we need to fix

[manishbobburi]

I'd love to work on this issue. Could you please assign it to me?

[reynaldichernando]

assigned!

[manishbobburi]

Hi team,

I looked into this issue to locate where the fix should go. It appears the billing dialog (window.UIUpgradeAccount) and the underlying subscription endpoints (/marketplace/subscriptions/...) are part of the closed-source/production marketplace extension (prodMeteringAndBilling), rather than the open-source repository.

To resolve this copy discrepancy (where downgrades show immediate success instead of a scheduled change), the success screen logic in the billing dialog needs to conditionally show a different string when the subscription change is pending/scheduled (since downgrades only take effect at the end of the billing period).

Proposed Fix:

1. In the open-source translation files (e.g., src/gui/src/i18n/translations/en.js), we can define a new key for scheduled plan changes:

   'billing.subscription_change_scheduled': 'Plan changed to %strong%, and will start once the current plan period ends.'

2. The closed-source billing dialog success modal needs to be updated to detect if the change is a scheduled downgrade/change, and load the new key instead of:

   'billing.you_are_now_subscribed_to'.

Should we add this translation key and update the proprietary billing logic to load it on scheduled downgrades? Let me know if you would like me to submit a PR to add the translation key to the open-source repository.

[reynaldichernando]

hi @manishbobburi , thanks for looking into this
let's hold off on this for now, since it involves some proprietary code
@Salazareo please advise

[manishbobburi]

hi @manishbobburi , thanks for looking into this let's hold off on this for now, since it involves some proprietary code @Salazareo please advise

Thanks for the update. Understood that this involves proprietary code, so I'll pause work on this for now and wait for further guidance.