[quirk] UIAlert stringifies value

[KernelDeimos]

The following code would not work as intended:

const answer = await UIAlert({
    message: `Press "yes" to perform dangerous action!`,
    buttons: [
        {
            label: i18n('yes'),
            value: true,
        },
        {
            label: i18n('no'),
            value: false,
        },
    ]
});
if ( answer ) do_dangerous_action();

Regardless of which button the user presses, do_dangerous_action() is called. This is because value is stringified unnecessarily. Instead of the value false, we get the value "false", which is truthy.

[jelveh]

I couldn't reproduce this. Pasted this exact code in the desktop, changed it worked as expected.

[dtakahashi333]

@jelveh I would like to work on this issue. Can you please assign it to me?

[jelveh]

Yesd @dtakahashi333! go for it :)

[dtakahashi333]

@KernelDeimos I have a potential patch for this issue. Could you please advise me on how to test my code?

[jelveh]

Could you open a pr? I'll take a look :)

[dtakahashi333]

Sure I will :)

[dtakahashi333]

@jelveh I have a question related to this issue. I noticed that the html_encode function currently returns an empty string for the boolean value false, whereas it returns 'true' for the boolean true. I'm wondering if this is the expected behavior.

Do you know where the html_encode function is defined?

[jelveh]

We use html-entities, so I'd say the behaviour you see in html_encode is a quirk of the html-entities module. Is this causing issues?

[dtakahashi333]

Thank you for the clarification!

That also explains why you weren’t able to reproduce the issue mentioned by @KernelDeimos, as answer becomes an empty string, which effectively bypasses the condition that triggers do_dangerous_action().

Since jQuery .attr() function always returns attribute values as strings, it's safer to recover the original value types after retrieving them from HTML elements when clicking buttons. This would help avoid the potential issue @KernelDeimos mentioned, by ensuring the values behave as expected in conditional logic.