Feat/stacked column chart react#78
Open
IlyesBenAmara wants to merge 18 commits into
Open
Conversation
marrouchi
requested changes
Oct 20, 2022
Contributor
marrouchi
left a comment
marrouchi
left a comment
There was a problem hiding this comment.
Looks good 👋 Left some comments ;)
marrouchi
force-pushed
the
feat/StackedColumnChart-react
branch
from
00b137f to
70cf3b5
Compare
marrouchi
requested changes
Oct 25, 2022
| ]); | ||
|
|
||
| return ( | ||
| return scopedSlots && scopedSlots.default ? ( |
Contributor
There was a problem hiding this comment.
Suggested change
| return scopedSlots && scopedSlots.default ? ( | |
| return <g className="ez-bars" {...rest}>CONDITION</g> |
| return ( | ||
| <g {...rest}> | ||
| {yDomainKeys.map((yDomainKey) => { | ||
| // @ts-ignore |
| const StackedColumnArguments = { | ||
| ...defaultArguments, | ||
| yAxis: { | ||
| domainKeys: ['value1', 'value', 'value2'], |
Contributor
There was a problem hiding this comment.
Suggested change
| domainKeys: ['value1', 'value', 'value2'], | |
| domainKeys: ['value', 'value1', 'value2'], |
| <ColorScale domain={yAxis.domainKeys} range={colors}> | ||
| {activeDomainKeys.map((activeDomaiKey) => { | ||
| return ( | ||
| // we need to find a way to sort the the data columns so that it shows bars in the corret manner |
Contributor
There was a problem hiding this comment.
Suggested change
| // we need to find a way to sort the the data columns so that it shows bars in the corret manner | |
| // We need to find a way to sort the the data columns so that it shows bars in the corret manner |
| }} | ||
| > | ||
| <ColorScale domain={yAxis.domainKeys} range={colors}> | ||
| {activeDomainKeys.map((activeDomaiKey) => { |
Contributor
There was a problem hiding this comment.
Suggested change
| {activeDomainKeys.map((activeDomaiKey) => { | |
| {activeDomainKeys.map((activeDomainKey) => { |
| // we need to find a way to sort the the data columns so that it shows bars in the corret manner | ||
| <Bars | ||
| xDomainKey={xAxis.domainKey} | ||
| yDomainKey={activeDomaiKey} |
Contributor
There was a problem hiding this comment.
Suggested change
| yDomainKey={activeDomaiKey} | |
| yDomainKey={activeDomainKey} |
Comment on lines
+113
to
+114
| shapeDatum.height > | ||
| previousShapeData[index].height |
Contributor
There was a problem hiding this comment.
Suggested change
| shapeDatum.height > | |
| previousShapeData[index].height | |
| index > 0 |
marrouchi
requested changes
Oct 25, 2022
…ara:Hexastack/eazychart into feat/StackedColumnChart-react
…ara:Hexastack/eazychart into feat/StackedColumnChart-react
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a new chart recipe called
StackedColumnChart.Note: if the review goes well, I will add the proper unit test for it and then continue my way on adding this recipe to the Vue package. (will probably use the same branch for the React unit tests)