Skip to content

Added Parties plugin integration#735

Merged
Draycia merged 3 commits intoHexaoxide:trunkfrom
JustusJG:trunk
Jan 26, 2026
Merged

Added Parties plugin integration#735
Draycia merged 3 commits intoHexaoxide:trunkfrom
JustusJG:trunk

Conversation

@JustusJG
Copy link
Contributor

@JustusJG JustusJG commented Dec 15, 2025

@jpenilla jpenilla changed the title Added [Parties](https://github.com/AlessioDP/Parties) integration Added Parties plugin integration Dec 15, 2025
@jpenilla
Copy link
Member

jpenilla commented Dec 15, 2025

This plugin name is a bit generic, maybe we could prefix the config id with alessiodp- and double-check the class name of the plugin class is correct in the eligible method?

build.gradle.kts Outdated
url("PlaceholderAPI", "https://www.spigotmc.org/resources/placeholderapi.6245/") {
required = false
}
url("Parties", "https://modrinth.com/plugin/parties") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested this with ./gradlew carbonchat-paper:runServer? should be using the modrinth method, not url for this.

@jpenilla
Copy link
Member

Heads up that checkstyle is failing - you can ./gradlew check locally to verify

@Draycia
Copy link
Member

Draycia commented Jan 26, 2026

Translations will have to be added through crowdin, since it doesn't roundtrip them (only pulls from en_US).
Other than that, LGTM

@Draycia Draycia merged commit 72caf16 into Hexaoxide:trunk Jan 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants