Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API1600 Support for Volume Attachment #420

Merged
merged 15 commits into from
May 26, 2020
Merged

Conversation

nabhajit-ray
Copy link
Collaborator

Description

[API1600 Support for Volume Attachment]

Issues Resolved

[]

Check List

  • New functionality includes testing.
    • All tests pass ($ rake test).
  • New functionality has been documented in the README if applicable.
    • New functionality has been thoroughly documented in the examples (please include helpful comments).
  • New endpoints supported are updated in the endpoints-support.md file.
  • Changes are documented in the CHANGELOG.

include_context 'shared context'

it 'inherits from OneviewSDK::API1200::C7000::VolumeAttachment' do
expect(described_class).to be < OneviewSDK::API1200::C7000::VolumeAttachment
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I see lib, it seems like this class should inherit from API1600::C7000. If so, please update comment accordingly.

@@ -0,0 +1,9 @@
require 'spec_helper'

RSpec.describe OneviewSDK::API1200::Synergy::VolumeAttachment do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Collaborator

@VenkateshRavula VenkateshRavula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check the inherit class in lib file and spec file.

@nabhajit-ray nabhajit-ray merged commit 59b72a1 into master May 26, 2020
@nabhajit-ray nabhajit-ray deleted the API1600VolumeAttachment branch May 26, 2020 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants