-
-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve whisky discoverability on mac #3747
Conversation
I can't seem to get the CI build working, it just says right after installing |
that is because the build file is not signed, you need to run this command from the macOS terminal for it to work: |
It seems that whisky's Whisky's latest version is indeed 2.3.2, but what's in the Application Support/Library/WhiskyWineVersion.plist is 2.2.0 Not idea why Current Heroic : This MR CI build: |
The version 2.2.0 is the same as whisky's wine version. Whisky updates wine in a different frequency than it updates the launcher(the .app itself) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#3728 (comment)
Use the same version detection method as Whisky
Ping @ahmed2m. I do not have Whisky installed. Please download the CI build to see if this works.
Use the following Checklist if you have changed something on the Backend or Frontend: