Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve whisky discoverability on mac #3747

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

WangEdward
Copy link
Contributor

@WangEdward WangEdward commented May 12, 2024

#3728 (comment)
Use the same version detection method as Whisky

Ping @ahmed2m. I do not have Whisky installed. Please download the CI build to see if this works.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@ahmed2m
Copy link

ahmed2m commented May 12, 2024

I can't seem to get the CI build working, it just says right after installing
“Heroic” is damaged and can’t be opened. You should move it to the Trash.

@flavioislima
Copy link
Member

I can't seem to get the CI build working, it just says right after installing “Heroic” is damaged and can’t be opened. You should move it to the Trash.

that is because the build file is not signed, you need to run this command from the macOS terminal for it to work:
xattr -d com.apple.quarantine path_to_Heroic.app

@flavioislima flavioislima added the pr:ready-for-review Feature-complete, ready for the grind! :P label May 20, 2024
@ahmed2m
Copy link

ahmed2m commented May 20, 2024

It seems that whisky's CFBundleShortVersionString in the package contents is not in sync with the Application Support one?

Whisky's latest version is indeed 2.3.2, but what's in the Application Support/Library/WhiskyWineVersion.plist is 2.2.0

Not idea why


Current Heroic :

Details

CleanShot 2024-05-20 at 16 43 39@2x

This MR CI build:

Details

CleanShot 2024-05-20 at 16 44 38@2x

@WangEdward
Copy link
Contributor Author

WangEdward commented May 21, 2024

Whisky's latest version is indeed 2.3.2, but what's in the Application Support/Library/WhiskyWineVersion.plist is 2.2.0

The version 2.2.0 is the same as whisky's wine version. Whisky updates wine in a different frequency than it updates the launcher(the .app itself)

Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flavioislima flavioislima merged commit 2cc9cae into Heroic-Games-Launcher:main Nov 18, 2024
9 checks passed
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants