-
-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GOG]: don't check for notInstallable during library sync #3711
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, I can't confirm the solution cause I never had the issue if games flagged as not installable in the first place
There is one flaw with this approach. Demos are treated as full releases because the endpoint we use collects different game editions under one entry. EDIT: Found the solution, latest commit addresses that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm but I have no way of testing it
I was experiencing this problem, I used the AppImage from this run https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/actions/runs/8850391069 and that fixed the issue for me. I shared my logs from 2.14.1 on a discord thread, and they are now correct and do not show any timeouts or other errors. |
This should resolve number of issues, but also allow players with pre-release access to actually download their games.
Use the following Checklist if you have changed something on the Backend or Frontend: