Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOG]: don't check for notInstallable during library sync #3711

Merged
merged 5 commits into from
Apr 27, 2024

Conversation

imLinguin
Copy link
Member

This should resolve number of issues, but also allow players with pre-release access to actually download their games.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@imLinguin imLinguin added the pr:ready-for-review Feature-complete, ready for the grind! :P label Apr 23, 2024
@imLinguin imLinguin requested review from a team, arielj, flavioislima, CommandMC, Etaash-mathamsetty and Nocccer and removed request for a team April 23, 2024 14:34
@imLinguin imLinguin linked an issue Apr 24, 2024 that may be closed by this pull request
Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, I can't confirm the solution cause I never had the issue if games flagged as not installable in the first place

@imLinguin
Copy link
Member Author

imLinguin commented Apr 25, 2024

There is one flaw with this approach. Demos are treated as full releases because the endpoint we use collects different game editions under one entry.

EDIT: Found the solution, latest commit addresses that

Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but I have no way of testing it

@daygr
Copy link

daygr commented Apr 26, 2024

I was experiencing this problem, I used the AppImage from this run https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/actions/runs/8850391069 and that fixed the issue for me. I shared my logs from 2.14.1 on a discord thread, and they are now correct and do not show any timeouts or other errors.

@arielj arielj merged commit 1c91af4 into main Apr 27, 2024
9 checks passed
@arielj arielj deleted the fix/not_installable_flow branch April 27, 2024 01:48
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

many random GOG games listed as "not installable"
4 participants