Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Accessibility option to always show titles in library without having to hover #3702

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Apr 17, 2024

This PR adds a new accessibility toggle to always show the cards' titles without having to hover/focus the card.

This can make finding games easier and it's particularly useful when using a screen with though capabilities where hover doesn't always make sense.

image


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Apr 17, 2024
@arielj arielj requested review from a team, flavioislima, CommandMC, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team April 17, 2024 20:05
allTilesInColor && 'allTilesInColor'
}`
const imgClasses = `gameImg ${isInstalled ? 'installed' : ''}`
const logoClasses = `gameLogo ${isInstalled ? 'installed' : ''}`
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved these classes to be applied in the list of games instead of in each game, since it applies to all games

@arielj arielj merged commit 925a0bd into main Apr 25, 2024
9 checks passed
@arielj arielj deleted the show-game-titles branch April 25, 2024 01:22
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants