Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] build selector exception on some locales #3683

Merged
merged 1 commit into from
May 17, 2024
Merged

Conversation

imLinguin
Copy link
Member

Fixes #3668

Turns out passing the locale from i18n isn't that good idea, it's just date formatting so now it will be done based on system locale.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@imLinguin imLinguin added the pr:ready-for-review Feature-complete, ready for the grind! :P label Apr 7, 2024
@imLinguin imLinguin requested review from a team, arielj, flavioislima, CommandMC, Etaash-mathamsetty and Nocccer and removed request for a team April 7, 2024 13:49
@arielj arielj merged commit 01d32fc into main May 17, 2024
9 checks passed
@arielj arielj deleted the fix/buildselector branch May 17, 2024 03:27
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when i tried install a GOG game
2 participants