-
-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX] Simplify install dialog hiding wine settings by default. Warn about shared wine directory #3547
Conversation
…hared wine directory.
I think having a button instead of the checkbox makes more sense here. We are hiding that element when it's checked, so it doesn't need to be a checkbox |
right, I originally added it as a checkbox cause I was not hiding it, but then there were 2 checkboxes together and it looked weird |
Can you make this button smaller or maybe use it like a link? Another idea would be to use a collapsible element, which may make more sense. |
I tried making it smaller and it also looks odd (I didn't push any of that, the code in this PR is still the checkbox). I can try with a details/summary element but I don't know if we have a style for that anywhere (I used it for the help component but it just the basic browser style, doesn't look great) |
…uncher into install-dialog-simplification
It's really common to see support requests of users that clicked the
Use Default Wine Settings
without understanding what it is for.This PR aims to solve that with 2 things:
Use Default Wine Settings
a warning is displayed to tell them to not use this option if they don't know what they are doingAlso, now when checking the
Use Default Wine Settings
option, the wine and prefix field are not hidden so users can see what that check box is doing (the fields are disabled so they don't change them).Use the following Checklist if you have changed something on the Backend or Frontend: