Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix/UX] Disable dragging elements #3514

Merged
merged 1 commit into from
Feb 4, 2024
Merged

[Fix/UX] Disable dragging elements #3514

merged 1 commit into from
Feb 4, 2024

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Feb 4, 2024

This PR fixes #3444

Everything is non-draggable now except for the sidebar resizer which still works as expected (I think there's no other element that is draggable.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Feb 4, 2024
@arielj arielj requested review from a team, flavioislima, CommandMC, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team February 4, 2024 03:17
flavioislima
flavioislima approved these changes Feb 4, 2024
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@flavioislima flavioislima added this to the 2.13.0 milestone Feb 4, 2024
@arielj arielj merged commit b232737 into main Feb 4, 2024
@arielj arielj deleted the disable-drag-and-drop branch February 4, 2024 13:22
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@flavioislima flavioislima flavioislima approved these changes

@CommandMC CommandMC Awaiting requested review from CommandMC CommandMC was automatically assigned from Heroic-Games-Launcher/development

@Etaash-mathamsetty Etaash-mathamsetty Awaiting requested review from Etaash-mathamsetty Etaash-mathamsetty was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

@imLinguin imLinguin Awaiting requested review from imLinguin imLinguin was automatically assigned from Heroic-Games-Launcher/development

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.

Remove drag and drop in menu icon
2 participants
@arielj @flavioislima