[Fix] Ensure manifest in install info #3508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielj
requested review from
a team,
flavioislima,
CommandMC,
Etaash-mathamsetty,
Nocccer and
imLinguin
and removed request for
a team
arielj
commented
Feb 3, 2024
| ].getInstallInfo(element.params.appName, element.params.platformToInstall, { | ||
| branch: element.params.branch, | ||
| build: element.params.build | ||
| }) |
There was a problem hiding this comment.
branch and build are not in an optional options 3rd argument for gog
arielj
commented
Feb 3, 2024
| @@ -73,7 +68,7 @@ export function addNewApp({ | |||
|
|
|||
| /* eslint-disable @typescript-eslint/no-unused-vars */ | |||
|
|
|||
| export function installState(appName: string, state: boolean) { | |||
| export function installState() { | |||
There was a problem hiding this comment.
we don't need the arguments in this functions because we don't use them
removing to avoid importing types we don't need
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When getting the install info for legendary games, it sometimes happens that we have invalid data cached that doesn't have
manifestinfo.In the past that lead to the InstallDialog to be stuck fetching the install info forever, with the latest changes for the gogdl_refactor that produces a javascript exception killing the react app:
Error: Cannot use 'in' operator to search for 'perLangSize' in null]This PR addresses that with 3 changes:
manifestproperty, it doesn't use the cache and fetches a new onemanifestproperty, it's retried up to 3 timesmanifestproperty after the retries, it throws an error instead of storing the wrong dataI had to do some changes in the parameters to be able to support different extra params for the different stores.
I understand this fixes #3249
Use the following Checklist if you have changed something on the Backend or Frontend: