Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix/Refactor] Make all logs async #3507

Merged
merged 6 commits into from
Feb 4, 2024
Merged

[Fix/Refactor] Make all logs async #3507

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d7320f0
Make all logs async
arielj Feb 3, 2024
9a67273
Remove correct LogWriter in stopLogger
arielj Feb 3, 2024
63b7b80
Fix tests
arielj Feb 3, 2024
64cb725
Uncomment test
arielj Feb 3, 2024
bba5895
Merge branch 'main' of github.com:Heroic-Games-Launcher/HeroicGamesLa…
arielj Feb 4, 2024
fc0b187
Handle getPath throwing error if invalid logs path
arielj Feb 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove correct LogWriter in stopLogger
  • Loading branch information
@arielj
arielj committed Feb 3, 2024
commit 9a67273cb8f9ce0840cb94333152b70f3355fed1
2 changes: 1 addition & 1 deletion src/backend/logger/logger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,7 @@ export function stopLogger(appName: string) {
logsWriters[`${appName}-lastPlay`]?.logMessage(
'============= End of log ============='
)
delete logsWriters[appName]
delete logsWriters[`${appName}-lastPlay`]
}

// LogWriter subclass to log to latest runner logs
Expand Down
Loading