[PROTON]: use run verb for setup commands #3505
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using
waitforexitandrun
for setup commands, which is slow as it first ensures that wineserver exited properly.run
is made for exactly the purpose of setup. With that we can re-use wineserver process and in turn make it faster.I also made changes to legendary's setup, as it was using function that could recursively call itself in some conditions. This change is here to prevent that from happening in the future when we make changes to when game setup commands are executed.
Proton-GE relies on the verb to determine if it should apply protonfixes, which will be useful for us with introduction of ULWGL.
There is one command I'm not yet sure about -
shutdownWine
function. I'll take care of it in ULWGL PR thoughUse the following Checklist if you have changed something on the Backend or Frontend: