Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROTON]: use run verb for setup commands #3505

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

imLinguin
Copy link
Member

We were using waitforexitandrun for setup commands, which is slow as it first ensures that wineserver exited properly.
run is made for exactly the purpose of setup. With that we can re-use wineserver process and in turn make it faster.

I also made changes to legendary's setup, as it was using function that could recursively call itself in some conditions. This change is here to prevent that from happening in the future when we make changes to when game setup commands are executed.

Proton-GE relies on the verb to determine if it should apply protonfixes, which will be useful for us with introduction of ULWGL.

There is one command I'm not yet sure about - shutdownWine function. I'll take care of it in ULWGL PR though

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@imLinguin imLinguin added the pr:ready-for-review Feature-complete, ready for the grind! :P label Feb 2, 2024
@imLinguin imLinguin requested review from a team, arielj, flavioislima, CommandMC, Etaash-mathamsetty and Nocccer and removed request for a team February 2, 2024 16:52
@flavioislima flavioislima added this to the 2.13.0 milestone Feb 4, 2024
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@flavioislima flavioislima modified the milestone: 2.13.0 Feb 4, 2024
@arielj arielj merged commit faa3ea6 into Heroic-Games-Launcher:main Feb 6, 2024
9 checks passed
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants