Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Wait for legendary refresh to finish before storing array #3452

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Jan 19, 2024

This PR fixes #3450

We were not waiting for the promise to finish, so the library was not updated with the new results from legendary, we were writing the old library to the store instead, requiring a second reload to get things updated.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jan 19, 2024
@arielj arielj requested review from a team, flavioislima, CommandMC, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team January 19, 2024 03:47
Copy link
Member

@Etaash-mathamsetty Etaash-mathamsetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arielj arielj merged commit 2665aed into main Jan 21, 2024
9 checks passed
@arielj arielj deleted the fix-legendary-initial-refresh branch January 21, 2024 17:09
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Epic library is not refreshed correctly at startup
2 participants