Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Fix width of image in Add Game dialog #3427

Merged
merged 1 commit into from
Jan 11, 2024
Merged

[UI] Fix width of image in Add Game dialog #3427

merged 1 commit into from
Jan 11, 2024

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Jan 10, 2024

This PR fixes #3423

Before:
image

After:
image

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jan 10, 2024
@arielj arielj requested review from a team, flavioislima, CommandMC, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team January 10, 2024 02:56
Etaash-mathamsetty
Etaash-mathamsetty approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@Etaash-mathamsetty Etaash-mathamsetty left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, lemme test
edit: works fine

@arielj arielj merged commit 36ee9f0 into main Jan 11, 2024
9 checks passed
@arielj arielj deleted the fix-add-game-image branch January 11, 2024 22:38
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Etaash-mathamsetty Etaash-mathamsetty Etaash-mathamsetty approved these changes

@flavioislima flavioislima Awaiting requested review from flavioislima flavioislima was automatically assigned from Heroic-Games-Launcher/development

@CommandMC CommandMC Awaiting requested review from CommandMC CommandMC was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

@imLinguin imLinguin Awaiting requested review from imLinguin imLinguin was automatically assigned from Heroic-Games-Launcher/development

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Visual bug in the "Add new game" menu
2 participants
@arielj @Etaash-mathamsetty