Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech] Truly ignore flatpak-build #3219

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Conversation

CommandMC
Copy link
Collaborator

This is an alternative PR to #2748
I didn't like the fact that we had to explicitly add the folder when invoking Prettier in the first place. It's already in our .prettierignore, so it should be... ignored. Newer versions of Prettier do this correctly, so this was solved by a simple update (and subsequently fixing all the new formatting rules)
In the process, I noticed that ESLint also had problems with this folder. Adding it to .eslintignore was all it needed


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • N/A - Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC CommandMC added the pr:ready-for-review Feature-complete, ready for the grind! :P label Nov 6, 2023
@CommandMC CommandMC requested a review from a team November 6, 2023 19:17
@CommandMC CommandMC self-assigned this Nov 6, 2023
@CommandMC CommandMC requested review from arielj, flavioislima, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team November 6, 2023 19:18
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@flavioislima flavioislima merged commit 7ba4fb3 into main Nov 21, 2023
13 checks passed
@flavioislima flavioislima deleted the fix/flatpak-build-ignore branch November 21, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants