-
-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tech] Move to pnpm #3192
[Tech] Move to pnpm #3192
Conversation
808e49d
to
98b2193
Compare
`copySync` never accepted a `recursive` parameter. Not sure how that didn't cause an error before
Electron-Builder and pnpm are not the best of friends, but this should make them work together while not sacrificing too many pnpm speedups
36360f4
to
396e1d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested here and is working fine.
would just be good to double check if AppVeyor has pnpm installed on their docker images already, otherwise the windows release will fail.
# Conflicts: # package.json # yarn.lock
Perhaps lets keep using npm or yarn on AppVeyor since it is just one of the builds and all the rest is working fine. |
Using something other than pnpm would still leave us without a lock file, but I guess that's better than it not working at all |
This should give us the best of both worlds, with working lockfile for packages but also a working electron-builder
This involved
Use the following Checklist if you have changed something on the Backend or Frontend: