Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Fix missing double quote on exe value #3131

Merged
merged 1 commit into from
Oct 13, 2023
Merged

[Fix] Fix missing double quote on exe value #3131

merged 1 commit into from
Oct 13, 2023

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Oct 13, 2023

This PR adds a missing " character at the end of the string when adding steam shortcuts on windows as explained here #3125

Thanks @HazardousBackup

Fixes #3125

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Oct 13, 2023
@arielj arielj requested review from a team, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team October 13, 2023 17:36
Etaash-mathamsetty
Etaash-mathamsetty approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@Etaash-mathamsetty Etaash-mathamsetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Etaash-mathamsetty Etaash-mathamsetty merged commit ade9091 into main Oct 13, 2023
@Etaash-mathamsetty Etaash-mathamsetty deleted the fix-missing-exe-quote branch October 13, 2023 21:03
stifflerstiff0 pushed a commit to stifflerstiff0/HeroicGamesLauncher that referenced this pull request Oct 14, 2023
@Etaash-mathamsetty @stifflerstiff0
[Fix] Fix missing double quote on exe value (Heroic-Games-Launcher#3131)
54cd3bd 
[FIX] Unset DOTNET_ROOT for wine (Heroic-Games-Launcher#3041)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Etaash-mathamsetty Etaash-mathamsetty Etaash-mathamsetty approved these changes

@flavioislima flavioislima Awaiting requested review from flavioislima flavioislima was automatically assigned from Heroic-Games-Launcher/development

@CommandMC CommandMC Awaiting requested review from CommandMC CommandMC was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

@imLinguin imLinguin Awaiting requested review from imLinguin imLinguin was automatically assigned from Heroic-Games-Launcher/development

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing " breaks launching from Steam with portable version of Heroic
2 participants
@arielj @Etaash-mathamsetty