Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech] Refactor Download Methods #3129

Merged
merged 12 commits into from
Oct 30, 2023
Merged

[Tech] Refactor Download Methods #3129

merged 12 commits into from
Oct 30, 2023

Conversation

flavioislima
Copy link
Member

@flavioislima flavioislima commented Oct 12, 2023

Replace all methods that use curl with the easydl lib.
EasyDL uses only native nodejs methods so has no dependencies. Split all files into chunks, supports resuming interrupted downloads, and has built-in progress report.

With this, we remove one package dependency from the app and also fix the wine manager on Snaps.

Also removed the downloaded and average speed from the wine manager since it was too bloated with info and breaking the line. So I kept only percentage and ETA.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima flavioislima mentioned this pull request Oct 12, 2023
12 tasks
@flavioislima flavioislima marked this pull request as ready for review October 18, 2023 10:37
@flavioislima flavioislima added the pr:ready-for-review Feature-complete, ready for the grind! :P label Oct 18, 2023
@flavioislima
Copy link
Member Author

I tried to update the tests for downloading and installing but they won't work since the download is handled by an external lib and it does not support file:// for URL.

Tried to solve it in different ways but realized that we would just adjust the code for the tests to pass.
Perhaps an e2e tests makes more sense for this page instead of jest.

@flavioislima flavioislima merged commit b466390 into main Oct 30, 2023
@flavioislima flavioislima deleted the refactor/wine_download branch October 30, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant