-
-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tech] Refactor Download Methods #3129
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
flavioislima
added
the
pr:ready-for-review
Feature-complete, ready for the grind! :P
label
Oct 18, 2023
flavioislima
requested review from
Nocccer,
arielj,
CommandMC,
Etaash-mathamsetty and
imLinguin
October 18, 2023 10:39
I tried to update the tests for downloading and installing but they won't work since the download is handled by an external lib and it does not support Tried to solve it in different ways but realized that we would just adjust the code for the tests to pass. |
…uncher into refactor/wine_download
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace all methods that use
curl
with theeasydl
lib.EasyDL uses only native nodejs methods so has no dependencies. Split all files into chunks, supports resuming interrupted downloads, and has built-in progress report.
With this, we remove one package dependency from the app and also fix the wine manager on Snaps.
Also removed the downloaded and average speed from the wine manager since it was too bloated with info and breaking the line. So I kept only percentage and ETA.
Use the following Checklist if you have changed something on the Backend or Frontend: