improv: avoid refreshing library too much

src/backend/downloadmanager/downloadqueue.ts

@@ -139,6 +139,7 @@ async function addToQueue(element: DMQueueElement) {
 
     if (
       element.params.runner === 'gog' &&
+      element.params.platformToInstall === 'windows' &&
       installInfo &&
       'dependencies' in installInfo.manifest
     ) {

src/backend/launcher.ts

@@ -38,7 +38,7 @@ import {
 import { GlobalConfig } from './config'
 import { GameConfig } from './game_config'
 import { DXVK } from './tools'
-import setup from './storeManagers/gog/setup'
+import gogSetup from './storeManagers/gog/setup'
 import nileSetup from './storeManagers/nile/setup'
 import {
   CallRunnerOptions,
@@ -241,7 +241,7 @@ async function prepareWineLaunch(
       LogPrefix.Backend
     )
     if (runner === 'gog') {
-      await setup(appName)
+      await gogSetup(appName)
     }
     if (runner === 'nile') {
       await nileSetup(appName)

src/backend/storeManagers/gog/games.ts

@@ -408,6 +408,9 @@ export async function install(
   const array = installedGamesStore.get('installed', [])
   array.push(installedData)
   installedGamesStore.set('installed', array)
+  gameInfo.is_installed = true
+  gameInfo.install = installedData
+  sendFrontendMessage('pushGameToLibrary', gameInfo)
   refreshInstalled()
   if (isWindows) {
     logInfo('Windows os, running setup instructions on install', LogPrefix.Gog)
@@ -416,7 +419,7 @@ export async function install(
     } catch (e) {
       logWarning(
         [
-          `Failed to run setup instructions on install for ${gameInfo.title}, some other step might be needed for the game to work. Check the 'goggame-${appName}.script' file in the game folder`,
+          `Failed to run setup instructions on install for ${gameInfo.title}`,
           'Error:',
           e
         ],
@@ -906,7 +909,7 @@ export async function uninstall({ appName }: RemoveArgs): Promise<ExecResult> {
   await removeShortcutsUtil(gameInfo)
   syncStore.delete(appName)
   await removeNonSteamGame({ gameInfo })
-  sendFrontendMessage('refreshLibrary', 'gog')
+  sendFrontendMessage('pushGameToLibrary', gameInfo)
   return res
 }
 
@@ -1189,7 +1192,8 @@ export async function forceUninstall(appName: string): Promise<void> {
   const installed = installedGamesStore.get('installed', [])
   const newInstalled = installed.filter((g) => g.appName !== appName)
   installedGamesStore.set('installed', newInstalled)
-  sendFrontendMessage('refreshLibrary', 'gog')
+  refreshInstalled()
+  sendFrontendMessage('pushGameToLibrary', getGameInfo(appName))
 }
 
 // GOGDL now handles the signal, this is no longer needed

src/backend/storeManagers/gog/library.ts

@@ -70,10 +70,12 @@ export async function initGOGLibraryManager() {
     await mkdir(manifestDir, { recursive: true })
   }
 
-  const credentials = await GOGUser.getCredentials()
-  for (const appName of installedGamesList) {
-    await createMissingGogdlManifest(appName, credentials)
-  }
+  runOnceWhenOnline(async () => {
+    const credentials = await GOGUser.getCredentials()
+    for (const appName of installedGamesList) {
+      await createMissingGogdlManifest(appName, credentials)
+    }
+  })
   runOnceWhenOnline(checkForRedistUpdates)
 }
 
@@ -91,18 +93,14 @@ async function createMissingGogdlManifest(
   // Pull the data, read info file from install dir if possible
   const res = await runRunnerCommand(
     ['import', installedData.install_path],
-    createAbortController(appName),
+    createAbortController(`${appName}-manifest-restore`),
     {
       logMessagePrefix: `Getting data of ${appName}`
     }
   )
-  deleteAbortController(appName)
+  deleteAbortController(`${appName}-manifest-restore`)
   try {
     const importData: GOGImportData = JSON.parse(res.stdout)
-    if (!importData.buildId) {
-      logError(`Unable to get data of ${appName}`, { prefix: LogPrefix.Gog })
-      return
-    }
     const builds = await getBuilds(
       appName,
       installedData.platform,
@@ -112,9 +110,9 @@ async function createMissingGogdlManifest(
 
     // Find our build in the list
 
-    const currentBuild = buildItems.find(
-      (item) => item.build_id === importData.buildId
-    )
+    const currentBuild = importData.buildId
+      ? buildItems.find((item) => item.build_id === importData.buildId)
+      : buildItems.find((item) => !item.branch)
     if (!currentBuild || !currentBuild.urls) {
       logError(`Unable to get current build of ${appName}`, {
         prefix: LogPrefix.Gog
@@ -132,6 +130,7 @@ async function createMissingGogdlManifest(
     }
     const manifestData = JSON.parse(manifestDataRaw.toString())
 
+    manifestData.HGLPlatform = importData.platform
     manifestData.HGLInstallLanguage = importData.installedLanguage
     manifestData.HGLdlcs = importData.dlcs.map((dlc) => ({ id: dlc }))
 
@@ -772,6 +771,10 @@ export async function importGame(data: GOGImportData, executablePath: string) {
   gameData.is_installed = true
   library.set(data.appName, gameData)
   installedGamesStore.set('installed', Array.from(installedGames.values()))
+  refreshInstalled()
+  await createMissingGogdlManifest(data.appName)
+  await checkForRedistUpdates()
+  sendFrontendMessage('pushGameToLibrary', gameData)
 }
 
 // This checks for updates of Windows and Mac titles

src/backend/storeManagers/gog/redist.ts

@@ -29,9 +29,10 @@ import {
 import { DMQueueElement } from 'common/types'
 import axios from 'axios'
 import { GOGUser } from './user'
+import { isOnline } from 'backend/online_monitor'
 
 export async function checkForRedistUpdates() {
-  if (!GOGUser.isLoggedIn()) {
+  if (!GOGUser.isLoggedIn() || !isOnline()) {
     return
   }
   const manifestPath = path.join(gogRedistPath, '.gogdl-redist-manifest')
@@ -80,10 +81,12 @@ export async function checkForRedistUpdates() {
           'https://content-system.gog.com/dependencies/repository?generation=2'
         )
         const newBuildId = response.data.build_id
-        logInfo('Updating redist, reason - new buildId', {
-          prefix: LogPrefix.Gog
-        })
         shouldUpdate = buildId !== newBuildId
+        if (shouldUpdate) {
+          logInfo('Updating redist, reason - new buildId', {
+            prefix: LogPrefix.Gog
+          })
+        }
       }
     } catch (e) {
       logError(['Failed to read gog redist manifest', e], {

src/frontend/state/GlobalState.tsx

@@ -657,7 +657,9 @@ class GlobalState extends PureComponent<Props> {
         })
       }
 
-      this.refreshLibrary({ runInBackground: true, library: runner })
+      if (runner !== 'gog') {
+        this.refreshLibrary({ runInBackground: true, library: runner })
+      }
       this.setState({ libraryStatus: newLibraryStatus })
     }
   }