Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech] Refactor Game Managers #2578

Merged
merged 26 commits into from
Apr 6, 2023
Merged
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
b9246ec
[Tech] Refactor game managers (#183)
BrettCleary Mar 17, 2023
42bc2a4
fix merge errors
BrettCleary Mar 28, 2023
4077228
fix build errors
BrettCleary Mar 28, 2023
3761817
rm unused vars
BrettCleary Mar 28, 2023
7cc5d04
prettier
BrettCleary Mar 28, 2023
d1ac2e7
Merge branch 'main' into tech/refactor_game_managers
BrettCleary Mar 28, 2023
6e97bfc
fix merge errors
BrettCleary Mar 28, 2023
6535396
change back to import folder
BrettCleary Mar 28, 2023
c004dd4
prettier fix
BrettCleary Mar 28, 2023
cb07624
revert importPath translation
BrettCleary Mar 28, 2023
f1d21d0
fix isNative check in main
BrettCleary Mar 28, 2023
12866ff
gog fixes
BrettCleary Mar 28, 2023
4fa0bfe
fix download manager successive installs
BrettCleary Mar 28, 2023
6261b35
fix gog import
BrettCleary Mar 28, 2023
4e616e7
fix deadcode
BrettCleary Mar 28, 2023
c97ed19
check anticheat on mac
BrettCleary Mar 28, 2023
242f960
rm main import
BrettCleary Mar 30, 2023
b151af0
add skip test on windows
BrettCleary Mar 30, 2023
063087b
Merge branch 'main' into tech/refactor_game_managers
BrettCleary Mar 30, 2023
40e050c
update games launch with merge changes
BrettCleary Mar 30, 2023
eaee68f
fix dead code
BrettCleary Mar 30, 2023
7cdc00b
move removeFolder to utils
BrettCleary Mar 30, 2023
7bcfb2d
import removeFolder fxn
BrettCleary Mar 30, 2023
4e0ae86
Merge branch 'main' of github.com:Heroic-Games-Launcher/HeroicGamesLa…
flavioislima Apr 6, 2023
6704007
chore: make variables names more generic
flavioislima Apr 6, 2023
3c436eb
tests: updated tests
flavioislima Apr 6, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rm main import
  • Loading branch information
BrettCleary committed Mar 30, 2023
commit 242f9608926ae7dd4ffbf3d8d77811e1829c68ce
9 changes: 7 additions & 2 deletions src/backend/downloadmanager/downloadqueue.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ import { DMQueueElement, DMStatus, DownloadManagerState } from 'common/types'
import { installQueueElement, updateQueueElement } from './utils'
import { sendFrontendMessage } from '../main_window'
import { callAbortController } from 'backend/utils/aborthandler/aborthandler'
import { removeFolder } from 'backend/main'
import { notify } from '../dialog/dialog'
import i18next from 'i18next'
import { ipcRenderer } from 'electron'

const downloadManager = new TypeCheckedStoreBackend('downloadManager', {
cwd: 'store',
Expand Down Expand Up @@ -188,7 +188,12 @@ function cancelCurrentDownload({ removeDownloaded = false }) {
if (removeDownloaded) {
const { appName, runner } = currentElement!.params
const { folder_name } = gameManagerMap[runner].getGameInfo(appName)
if (folder_name) removeFolder(currentElement.params.path, folder_name)
if (folder_name) {
ipcRenderer.send('removeFolder', [
currentElement.params.path,
folder_name
])
}
}
currentElement = null
}
Expand Down