[Tech] AppVeyor Configuration #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 40a67fb.
flavioislima
added
pr:ready-for-review
flavioislima
commented
Aug 8, 2022
| @@ -42,6 +42,7 @@ | |||
| } | |||
| ], | |||
| "win": { | |||
| "artifactName": "Heroic_Setup_${version}.${ext}", | |||
There was a problem hiding this comment.
the artifact cannot contain spaces on the name so I needed to change it.
Nocccer
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add the Appveyor configuration to sign the windows artifacts with the certificate that SignPath will provide to us.
The tests already passed and they confirmed that everything is ok.
We just got the prod certificate and I updated the flow to run only on tags.
Use the following Checklist if you have changed something on the Backend or Frontend: