-
-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Epic] Fix: Pass empty SDL tag properly #1481
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I tried this with fortnite and it works |
@CommandMC maybe this PR can be done against the main branch instead of beta? in case we do another fix release, so we don't forget to backport this |
4a0a842
to
4a32962
Compare
Hm, not quite sure what's up with the checks. Can you skip them somehow? |
Maybe @flavioislima can trigger them. I can't and manually starting them does not work. |
Maybe GH is down again. Try sending a empty commit. |
I think it didn't like that I pushed a commit with the exact same message as before |
I think it is fine to merge now! :D |
Wasn't entirely sure how this worked in #1443, didn't test it enough to find this issue
To test, just install Fortnite (or any other game that supports SDL) and see that important files (like the actual executable) are now getting downloaded
Use the following Checklist if you have changed something on the Backend or Frontend: