Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic] Fix: Pass empty SDL tag properly #1481

Merged
merged 2 commits into from
Jun 23, 2022
Merged

[Epic] Fix: Pass empty SDL tag properly #1481

merged 2 commits into from
Jun 23, 2022

Conversation

CommandMC
Copy link
Collaborator

Wasn't entirely sure how this worked in #1443, didn't test it enough to find this issue

To test, just install Fortnite (or any other game that supports SDL) and see that important files (like the actual executable) are now getting downloaded


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC CommandMC added the pr:testing This PR is in testing, don't merge. label Jun 15, 2022
@CommandMC CommandMC requested a review from Nocccer June 15, 2022 23:24
@Nocccer Nocccer linked an issue Jun 18, 2022 that may be closed by this pull request
Copy link
Collaborator

@Nocccer Nocccer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@CommandMC CommandMC added pr:ready-to-merge This PR is fully ready for merge. and removed pr:testing This PR is in testing, don't merge. labels Jun 18, 2022
@Etaash-mathamsetty
Copy link
Member

I tried this with fortnite and it works

@arielj
Copy link
Collaborator

arielj commented Jun 18, 2022

@CommandMC maybe this PR can be done against the main branch instead of beta? in case we do another fix release, so we don't forget to backport this

@CommandMC CommandMC force-pushed the fix/sdl-empty-tag branch from 4a0a842 to 4a32962 Compare June 23, 2022 08:45
@CommandMC CommandMC changed the base branch from beta to main June 23, 2022 08:45
@CommandMC CommandMC requested a review from arielj June 23, 2022 08:46
@CommandMC CommandMC added pr:ready-for-review Feature-complete, ready for the grind! :P and removed pr:ready-to-merge This PR is fully ready for merge. labels Jun 23, 2022
@CommandMC
Copy link
Collaborator Author

Hm, not quite sure what's up with the checks. Can you skip them somehow?

@Nocccer
Copy link
Collaborator

Nocccer commented Jun 23, 2022

Maybe @flavioislima can trigger them. I can't and manually starting them does not work.

@flavioislima
Copy link
Member

Maybe GH is down again. Try sending a empty commit.

@CommandMC
Copy link
Collaborator Author

I think it didn't like that I pushed a commit with the exact same message as before

@flavioislima
Copy link
Member

I think it is fine to merge now! :D

@CommandMC CommandMC merged commit 4ddf2e2 into main Jun 23, 2022
@CommandMC CommandMC deleted the fix/sdl-empty-tag branch June 23, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fortnite does not launch
5 participants