Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hermes needs an active maintainer #237

Open
winny- opened this issue Jun 30, 2015 · 46 comments
Open

Hermes needs an active maintainer #237

winny- opened this issue Jun 30, 2015 · 46 comments

Comments

@winny-
Copy link
Contributor

winny- commented Jun 30, 2015

Hi!

It has come to my attention that I don't have the time and ambition to maintain Hermes, so I'm looking for a dedicated maintainer to actively work on Hermes. In addition I won't have a Mac to maintain Hermes with, starting in a few weeks. I do intend to contribute back where it's sensibile -- e.g. I might end up with an old mac mini for some work projects, so maybe this won't be the last of my contributions. Regardless, we should find somebody that better fits the project responsibilities.

One person that comes to mind is @aahung.

Any thoughts, comments, feedback is welcome.

@bradmkjr
Copy link

bradmkjr commented Jul 3, 2015

Thank you for all that you have done, and the rest of the Hermes team. It has been a great project and really do not want to see it become abandonware. I don't have the technical ability to be any help, and my needs probably differ too far from the majority of users (I'm still on 10.8.5).

@aahung
Copy link
Contributor

aahung commented Jul 4, 2015

Hermes is a great projects due to many contributors. I would like to continue to contribute more. I don't have adequate skills and experience (I am gaining), hope to form a maintain group.

@nriley nriley mentioned this issue Aug 19, 2015
@nriley
Copy link
Contributor

nriley commented Oct 11, 2015

I should mention that this goes for me too — unlike @winny- I do still use a Mac every day but am busier than I've ever been at work and have multiple open source projects of my own that I'm trying to keep maintained as well. I've really enjoyed working on Hermes and really enjoyed seeing it flourish, but unfortunately can't be part of its development in the forseeable future.

@obycode
Copy link
Contributor

obycode commented Oct 15, 2015

I'd like to help keep this project alive. I have only recently discovered Hermes and I love it. I've already made some changes to make it build with Xcode 7, to send the distributed notifications immediately, and to add a distributed notification for player state changes. I'd be happy to contribute here and there.

@DrPat
Copy link

DrPat commented Oct 15, 2015

awesome... I use Hermes... but unfortunately I am not a coder.

On Thu, Oct 15, 2015 at 6:22 AM, obycode notifications@github.com wrote:

I'd like to help keep this project alive. I have only recently discovered
Hermes and I love it. I've already made some changes to make it build with
Xcode 7, to send the distributed notifications immediately, and to add a
distributed notification for player state changes. I'd be happy to
contribute here and there.


Reply to this email directly or view it on GitHub
#237 (comment).

Thank you for your attention,

Maurice P. O'Connor

@nriley
Copy link
Contributor

nriley commented Oct 16, 2015

@obycode Great! Please feel free to fork away :-)

@obycode
Copy link
Contributor

obycode commented Oct 16, 2015

@nriley I have forked and submitted a pull request, but CI didn't seem to like it and I'm not sure why. I'll need to spend some time figuring out what is wrong there.

@nriley
Copy link
Contributor

nriley commented Oct 17, 2015

Ugh, sorry :-/ Good luck.

@dwaite
Copy link
Contributor

dwaite commented Mar 1, 2016

I'd also be interested in keeping the app alive

@nriley
Copy link
Contributor

nriley commented Mar 5, 2016

Great. Perhaps a couple of you could start a fork, start contributing to it and if it makes some decent progress it can replace the "official" version here?

@nriley
Copy link
Contributor

nriley commented Mar 5, 2016

It might help to merge some of the outstanding pull requests... the networking one @dwaite filed looks like a good candidate!

@sheykh-sleky
Copy link

I can compile, test, and grep logs all day long. But that isn't anything to write home. Happy to test, and assist where I can. Alas my coding skills are, er, coding skills? hehe... Still. The integration with the keyboard (play, pause, next) is hands down, why this cannot die!

@amites
Copy link

amites commented Apr 17, 2016

@aahung are you still interested in working on this?

If no-one else wants to stand up for this one, I'm willing to keep active on top of pull requests and some fixes (no guarantees to pleasing everyone but I'd like to see this stay alive)

@sm11963
Copy link

sm11963 commented Apr 17, 2016

I am interested in contributing to this project. I am experienced with iOS dev but haven't worked with Mac apps before. I've been using Hermes for 2 years now and just realized its maintenance has been dropped :(.

I don't have the time right now to jump in head first but come June I should have some extra time to dedicate. I would really hate to see this application go under.

@nriley
Copy link
Contributor

nriley commented Apr 17, 2016

Thanks folks! I would recommend one or more of you fork Hermes and start merging patches. If there becomes a consensus I can give you access to the project and at some point we will figure out the way to share the appropriate information for making an actual release!

@jmjones88
Copy link
Contributor

I'd be interested in taking on ownership on Hermes. I've already forked it and have it building on OS 10.11(Ah the deprecations!), and seems to be running, after much work on compiler issues.

I still have some issues, like getting an error code 9 on initial login, but hopefully I'll have it fixed up soon. I'll make a pull request once it's running correctly.

@jmjones88
Copy link
Contributor

Travis CI has passed all the building checks, so it should be good to go for Xcode 7.3 - Pull Request #262 . I'll keep working to merge all the existing patches in to it as well

@nriley
Copy link
Contributor

nriley commented Apr 21, 2016

Awesome! Will take a look later this week — one warning for the future (from personal experience :-) is to make sure with the deprecation fixes that you're clear about your eventual OS minimum requirement.

@jmjones88
Copy link
Contributor

Great. Thanks for the tip! The biggest change was using NSRunningApplication (available in OS 10.6 and later) instead of ProcessSerialNumber (Which was deprecated in 10.9 i believe) to deal with hotkey support. Everything else was mainly syntax changes

@obycode
Copy link
Contributor

obycode commented Apr 21, 2016

@jmjones88 - I just created a pull request to your repo with the two changes that I'd like to see that help Hermes work better with third parties using the notifications. I'd be happy to help with maintenance work too.

@jmjones88
Copy link
Contributor

@obycode Thanks for that, I merged your requests in. Also thank you for all the work you did updating it for Xcode 7, it sure was a great resource

@obycode
Copy link
Contributor

obycode commented Apr 21, 2016

Great, I'm glad it could help! I never had the time to go through and get it passing the tests.Thanks for finishing that up!

@aahung
Copy link
Contributor

aahung commented Apr 23, 2016

I live in Hong Kong and I don't use Pandora very often. But, yep I will be here to help fix something if I can.

@nriley
Copy link
Contributor

nriley commented Apr 23, 2016

Okay, merged and listening to the new Hermes at the moment! Updated the release notes too. Next thing I think we need to work on is getting the Web site updated and making a release. I've never actually done a release myself but can track down some info that @winny- and @alexcrichton sent me.

@nriley
Copy link
Contributor

nriley commented May 8, 2016

OK, I fixed a bunch more stuff (please keep in mind this is not sustainable for me) and built a beta. Can't figure out how to upload it to S3 at the moment, but here it is on my Web site: https://sabi.net/temp/Hermes-1.2.7b1.zip.

If this works for people, I'll release it and then hopefully hand over the reins to someone(s) else.

@obycode
Copy link
Contributor

obycode commented May 10, 2016

I've been playing with it this morning and it works great.

@patricklewis
Copy link

I haven't encountered any problems with 1.2.7b3 so far, nice work!

@nriley
Copy link
Contributor

nriley commented May 11, 2016

OK, 1.2.7 is released with a bunch of changes — thanks to everyone who contributed. I still need to document the release process, which has changed (for the better, I think — everything is now hosted on GitHub rather than S3). Barring any catastrophic issues, I hope this will be good enough for a while to give some other folks a chance to get up to speed.

@cpowell
Copy link

cpowell commented May 12, 2016

Thumbs up to everyone who contributed to 1.2.7. Thanks very much for keeping this great app alive.

@nriley
Copy link
Contributor

nriley commented May 13, 2016

The release process is now documented. Let me know or post to this issue when you're ready for 1.2.8 or 1.3.0 or whatever and I'll make the necessary project changes.

@nriley
Copy link
Contributor

nriley commented Jun 19, 2016

I have done a bit more cleanup and fixed a bunch more bugs, including a regression introduced in 1.2.7, which will hopefully give the app a bit more time to find its footing with other maintainers.

Sorry to abuse this issue, but I imagine the participants have some interest in Hermes. Please test and file issues with any problems, particularly regressions!

Download: https://github.com/HermesApp/Hermes/releases/tag/v1.2.8b4

Changelog: https://github.com/HermesApp/Hermes/blob/master/CHANGELOG.md

@sammcj
Copy link

sammcj commented Jun 28, 2016

May I may a suggestion that given all the great work that @nriley has done for Hermes - that the project gets moved to his Github as the 'main' maintainer?

@nriley
Copy link
Contributor

nriley commented Jun 28, 2016

I appreciate the thought, but please no — the point of a lot of my work and doing things like documenting the release process was to make it easier for other people to get involved. I made a pile of cleanups/fixes in the last couple months because I had a lighter-than-usual work schedule, but I do not expect this to continue in the future and I also have a lot of my own open-source software that needs work. I did start using Hermes again myself which certainly contributed to my enthusiasm, though!

Hopefully some other folks can continue to pitch in. I think the code is in pretty good shape at this point, there are a bunch of open tickets, and I’m more than happy to answer questions going forward. Particularly there seem to be some signifcant crashing bugs with the 10.12 beta I don't know if/when I'll have time to address as I don't even have a 10.12 install right now (#258).

reedloden added a commit to reedloden/maintainers-wanted that referenced this issue Aug 15, 2016
See HermesApp/Hermes#237 for verification.
@AdibMurshed
Copy link

AdibMurshed commented Nov 7, 2017

Hello @winny- @HermesApp @nriley !
I am Adib Murshed, the President of the Iniftar Foundations. I would like to claim this project to continue its development, open-source and non-profit.

@winny-
Copy link
Contributor Author

winny- commented Nov 7, 2017

Hello, make sure to highlight @nriley - he's the guy to talk to. Best of luck :)

@AdibMurshed
Copy link

@nriley

@nriley
Copy link
Contributor

nriley commented Nov 19, 2017

Thanks @winny- - was on vacation. The comment you responded to was deleted and I could never figure out what it was about in any case... FYI for anyone else, if you want to start contributing, just do so, you don't need to ask permission :-)

@Raab70
Copy link

Raab70 commented Dec 13, 2017

@nriley I would be interested in contributing. Objective-C is not my forte but I can handle smaller issues especially if someone else just wants to review my work. I tackled a simple issue (#320) to get started.

@pmetzger
Copy link

What's the deal with maintenance at this point?

@nriley
Copy link
Contributor

nriley commented Oct 23, 2018 via email

@pmetzger
Copy link

But has anyone else been given commit rights over the app so they can maintain things, merge pull requests, etc.?

@dtseto
Copy link

dtseto commented Sep 9, 2024

But has anyone else been given commit rights over the app so they can maintain things, merge pull requests, etc.?

Just fork it and do pull requests? People who want to maintain it and take over the project might also add malware to it.

@nriley
Copy link
Contributor

nriley commented Sep 9, 2024

But has anyone else been given commit rights over the app so they can maintain things, merge pull requests, etc.?

Just fork it and do pull requests? People who want to maintain it and take over the project might also add malware to it.

Agreed, if you want to work on it, just fork it and get started; there have been some pretty high-profile cases of the malware thing recently when bad actors are added as contributors.

I'm in a slightly better place to handle contributions than I was a few years ago, but don't have enough time/ability to resume actively maintaining Hermes — though I use it daily. I'd only recommend doing this if you're a competent Cocoa developer already.

@dtseto
Copy link

dtseto commented Oct 28, 2024

I did a quick fork and build in macos 11 xcode 12.5. You are right it is a lot of work if you are not expert in Cocoa.

Kudos to you btw for being able to support FOSS with a day job as a MD. I as a JD am stop and go.

https://github.com/dtseto/Hermes-master/releases/tag/prerelease

@macOS-Mavericks
Copy link

Folks are jacked up for the silicon rebirth of Hermes - https://www.reddit.com/r/macapps/comments/1ggq1fn/hermes_silicon_fork_in_2024_free_open_source/ .

@dtseto
Copy link

dtseto commented Nov 1, 2024

Folks are jacked up for the silicon rebirth of Hermes - https://www.reddit.com/r/macapps/comments/1ggq1fn/hermes_silicon_fork_in_2024_free_open_source/ .

Damn. Thanks for the shoutout! I was wondering why people were starring my project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests