fixes #126 @1h

Author: HerbertKoelman

CHANGELOG

@@ -1,4 +1,5 @@
 2.3.0
+- Remove commented out code (#126)
 - make logger::logger rule zero compliant (#123)
 - write more logger::sink tests (#124)
 - fixed a bug in ./tests/CMakeLists.txt that prevented exception_tests to be run (#121)

include/logger/facilities.hpp

@@ -65,8 +65,6 @@ namespace logger {
                 // intentional...
             }
 
-            // virtual ~facility() ;
-
         private:
             const facility_code _code;
             const char         *_keyword;

include/logger/registry.hpp

@@ -147,7 +147,9 @@ namespace logger {
         template<class T, typename... Args> logger_ptr get( const std::string &name, const Args&... args){
           std::lock_guard<std::mutex> lck(_mutex);
 
-          // printf("DEBUG logger::registry.get(%s, %d);\n", name.c_str(), _level);
+#         ifdef DEBUG
+          printf("DEBUG logger::registry.get(%s, %d);\n", name.c_str(), _level);
+#         endif
 
           logger_ptr logger;
           auto search = _loggers.find(name);
@@ -178,7 +180,6 @@ namespace logger {
         };
 
         ~registry() = default;
-        // ~registry() { std::cout << "DEBUG delete registry..." << std::endl ; };
 
       private:
 

include/logger/sinks.hpp

@@ -170,8 +170,6 @@ namespace logger {
          */
         explicit file_sink(FILE *file);
 
-        // virtual ~file_sink() ;
-
         /** \copydoc sink::write()
          *
          * This sink writes messages in FILE.
@@ -293,7 +291,7 @@ namespace logger {
          */
         explicit syslog_sink();
 
-        ~syslog_sink() = default ; //override ;
+        ~syslog_sink() = default ;
 
         /** \copydoc  sink::write
          *

src/file_sink.cpp

@@ -50,11 +50,6 @@ namespace logger {
         _lag = buffer;
     };
 
-// TODO remove this
-//    file_sink::~file_sink() {
-//        //fflush(_file_descriptor);
-//    };
-
     void file_sink::set_name(const std::string &name) {
         sink::set_name(name);
 
@@ -85,7 +80,7 @@ namespace logger {
 
             // new character vector
             // vsnprintf returns the needed characters to store the output
-            // not possible with XL C/C++ std::vector<char> buf(1+std::vsnprintf(NULL, 0, fmt, args1));
+            //NOSONAR not possible with XL C/C++ std::vector<char> buf(1+std::vsnprintf(NULL, 0, fmt, args1));
 
             // this call only returns the actual number of bytes needed to store the message.
             // It doesn't count the needed end-of-string

src/registry.cpp

@@ -99,7 +99,9 @@ namespace logger {
 
     registry::registry() noexcept : _level(log_levels::info), _pname("program") {
         // intentional...
-        //std::cout << "DEBUG Create regsistry instance..." << std::endl;
+#       ifdef DEBUG
+        std::cout << "DEBUG Create regsistry instance..." << std::endl;
+#       endif
     }
 
 } // namespace logger

src/syslog_sink.cpp

@@ -59,10 +59,6 @@ namespace logger {
         // intentional
     }
 
-//    syslog_sink::~syslog_sink() {
-//        // intentional
-//    };
-
     void syslog_sink::write(log_level level, const char *fmt, ...) {
 #ifdef DEBUG
         printf("DEBUG %s _level/level: %d/%d, pattern: [%s] (%s,%d)\n", __FUNCTION__, _level, level, _pattern.c_str(), __FILE__,__LINE__);