Merge branch '123-logger-rule-zero' into 125-fix-sonar-issues

Author: HerbertKoelman

CHANGELOG

@@ -1,4 +1,5 @@
 2.3.0
+- make logger::logger rule zero compliant (#123)
 - write more logger::sink tests (#124)
 - fixed a bug in ./tests/CMakeLists.txt that prevented exception_tests to be run (#121)
 - activate soanrcloud checks (#120)

cmake/SonarCloudConfig.cmake

@@ -48,7 +48,7 @@ if ( SONAR )
     message(SEND_ERROR "Failed to find the program [sonar_scanner], make sure sonar tools are installed.")
   endif()
 
-else()
-  message(WARNING "SONAR cloud build is turned off, use -DSONAR=yes to turn in ON")
+#else()
+#  message(WARNING "SONAR cloud build is turned off, use -DSONAR=yes to turn in ON")
 endif()
 

include/logger/logger.hpp

@@ -190,13 +190,9 @@ namespace logger {
        */
       logger( const std::string &name, sink *sink);
 
-      /** dispose of logger's ressources
-       */
-      virtual ~logger();
-
     private:
 
-      sink        *_sink; //!< logger delegate to a sink the actual magic to write log messages
+      std::unique_ptr<sink>        _sink; //!< logger delegate to a sink the actual magic to write log messages
 
       std::string _name; //!< logger's name
     }; // logger

src/logger.cpp

@@ -14,15 +14,8 @@ namespace logger {
     // constructors & destructors -------------------------------------
     //
 
-    logger::logger(const std::string &name, sink *sink) : _sink(NULL), _name (name) {
-        _sink = sink;
-    }
-
-    logger::~logger() {
-        // printf("DEBUG %s destructor (%s,%d).\n", __FUNCTION__, __FILE__, __LINE__);
-        if (_sink != NULL) {
-            delete _sink;
-        }
+    logger::logger(const std::string &name, sink *sink) : _name (name) {
+        _sink.reset(sink);
     }
 
     std::string logger::ecid() {