Conversation
Merge main to dev
- Replaced deprecated `kotlinOptions.jvmTarget = "17"` with
`kotlin { compilerOptions { jvmTarget.set(JvmTarget.JVM_17) } }`
- Move FocusRequester inside AlertDialog content - Ensure requestFocus is triggered within LaunchedEffect scoped to text field
- Added Android 16 method signature for PhoneWindowManager.init
- Renamed tryHookMethod → tryHookInitMethod for clarity
- Simplified init() logic using also{} to handle hook result
- Minor log message updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build configuration
kotlinOptions.jvmTargetto the moderncompilerOptionsAPI.Android SDK
compileSdkandtargetSdkfrom 35 → 36.UI — NumberAlertDialog
FocusRequesterinside theAlertDialogcontent to scope it properly.LaunchedEffectto ensurerequestFocus()is triggered at the right moment.Module — VolumeControlModule
PhoneWindowManager.initmethod signature.tryHookMethod→tryHookInitMethodfor better naming consistency.initlogic to use.also {}for concise flow.Module — VolumeKeyControlModuleHandlers
abortAll()to abort allMediaEvententries instead of a fixed subset.