Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/images on s3 #33

Merged
merged 20 commits into from
Oct 9, 2019
Merged

Feature/images on s3 #33

merged 20 commits into from
Oct 9, 2019

Conversation

erik-sn
Copy link
Collaborator

@erik-sn erik-sn commented Oct 6, 2019

No description provided.

@erik-sn erik-sn requested a review from HendrikPN October 6, 2019 18:13
HendrikPN
HendrikPN requested changes Oct 7, 2019
View reviewed changes
Copy link
Owner

@HendrikPN HendrikPN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed as much as I could. I also ran it boht locally and remotely. Most of the functions seem to be working except the display of the getStarted.js on the frontend and image deletion on the local api file system.

scigym/images/utils.py Show resolved Hide resolved
scigym/images/utils.py Show resolved Hide resolved
scigym/images/signals.py Outdated Show resolved Hide resolved
@HendrikPN HendrikPN merged commit 02814e7 into HendrikPN:master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HendrikPN HendrikPN HendrikPN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erik-sn @HendrikPN