Quilt (& intermediary) support #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonymous123-code
commented
Jul 27, 2023
anonymous123-code
commented
- Intermediary and Quilt support
- Does not add stuff required for dependency stuff (And thus proper launcher support, although its usable with manual component editing)
- No caching (sha and content-length require two requests per library)
- It uses the corresponding last-modified header, although those arent the most reliable (especially quilt's has a cutoff at 2023-04-30)
setting the wrong url (was maven root) Also the first special casing for broken stuff
(no xml parsing needed anymore)
Closed
|
Okay so, the thing here is that I'm not sure if I'd want to run this code twice per hour without caching. How's the performance on this? |
|
It likely isn't good enough tbh. The code takes like 10 minutes (even when rerunning). I will change this to use caching when I have more time. |
- Lots of async (It felt like caching isnt even needed anymore) - Lots of caching (Best case only the request for update checking is needed)
- Lots of async - Lots of caching (Best case only the request for update checking is needed) - cargo fmt
|
I now reworked everything to be concurrent and implemented caching. For downloads, the hashes are stored per version, not per download version. So there is room for more caching, although I doubt it is necessary. https://helixlauncher-meta-test.pages.dev/ |
|
Note that because Im using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.