Fix broken join backoff #299
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the join backoff is broken. The defines for the join dutycycle are placeholder values that have been there since the library's creation. In the file where they are used (RegionCommon.c) they are
This is why there is no backoff regardless of how long the node has been running...
What they should be is defined in a different file, in (LoRaMac.c) they are defined again but NEVER used
Almost all other repos that use the SemTech Lora library have the values that are in LoRaMac.c in RegionCommon.c. By doing that, join backoff can actually function.