Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onetime cli param #76

Merged
merged 2 commits into from
Feb 10, 2022
Merged

Add onetime cli param #76

merged 2 commits into from
Feb 10, 2022

Conversation

sseide
Copy link
Contributor

@sseide sseide commented Feb 10, 2022

Patch to add new -onetime command line parameter to run the templateing process only once and exit afterwards.
This command line param overwrite the "Onetime" flag from all backend resources configured.

Issue related: #74

I have not found a place where to add this to the current documentation below the docs/ directory. Only mentioned flag inside the readme file instead.

Current patch is working as long as templates can be rendered - every is created and "remco" exits.

And another problem i found - current implementation does not respect the "onetime" config flag in case of an error (e.g. Network/Host unreachable, password wrong or templates not found etc.). Running into such a problem "remco" goes into an endless loop and retries again and again making the "Onetime" config param kinda useless.

I think remco should not go into a loop retrying when "ontime" flag is set for a specific config. What do you think?

@HeavyHorst
Copy link
Owner

HeavyHorst commented Feb 10, 2022

I think remco should not go into a loop retrying when "ontime" flag is set for a specific config. What do you think?

Agreed. Could you create another pull request?

@HeavyHorst HeavyHorst merged commit 5c7da1d into HeavyHorst:master Feb 10, 2022
@sseide sseide deleted the add_onetime branch February 21, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants